Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set test-structuredclone-* as flaky #50261

Merged
merged 1 commit into from
Oct 19, 2023
Merged

test: set test-structuredclone-* as flaky #50261

merged 1 commit into from
Oct 19, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 18, 2023

Ref: #50260

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
@anonrig anonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. and removed test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Oct 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54981/

@StefanStojanovic StefanStojanovic mentioned this pull request Oct 19, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55001/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit f9c290f into nodejs:main Oct 19, 2023
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f9c290f

This was referenced Oct 20, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig @targos
test: set test-structuredclone-* as flaky
9bc5ab5 
PR-URL: #50261
Refs: #50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
test: set test-structuredclone-* as flaky
ff2fb4d 
PR-URL: nodejs#50261
Refs: nodejs#50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
test: set test-structuredclone-* as flaky
5d4b5ff 
PR-URL: #50261
Refs: #50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @targos
test: set test-structuredclone-* as flaky
83e339d 
PR-URL: #50261
Refs: #50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
mertcanaltin pushed a commit to mertcanaltin/node that referenced this pull request Dec 19, 2023
@anonrig @mhdawson @mertcanaltin
test: set test-structuredclone-* as flaky
9b63e7c 
PR-URL: nodejs#50261
Refs: nodejs#50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

meta: move Trott to TSC regular member

At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs#50297
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>

node-api: refactor napi set property function for improved performance

fix: lint

fix: lint

refactor: Improve performance by using internalized property keys

refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16

lint

lint

fix: Resolve compilation error in node_api_create_property_key_utf16

fix: Resolve type conversion error in node_api_create_property_key_utf16

refactor: Simplify node_api_create_property_key_utf16 implementation

lint

add node_api_create_property_key_utf16 property name

added doc for node_api_create_property_key_utf16

lint

lint

update napi doc for node_api_create_property_key_utf16

update: code snipet

test: added test for node_api_create_property_key_utf16

lint

lint

lint

call node_api_create_property_key_utf16

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

added TestPropertyKeyUtf16 napi_property_descriptor

lint doc

lint cpp

minor updates to PR nodejs#50282

feat: removed not used function for test

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>
mertcanaltin pushed a commit to mertcanaltin/node that referenced this pull request Dec 19, 2023
@anonrig @mhdawson @mertcanaltin
test: set test-structuredclone-* as flaky
9523e2c 
PR-URL: nodejs#50261
Refs: nodejs#50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

meta: move Trott to TSC regular member

At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs#50297
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>

node-api: refactor napi set property function for improved performance

fix: lint

fix: lint

refactor: Improve performance by using internalized property keys

refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16

lint

lint

fix: Resolve compilation error in node_api_create_property_key_utf16

fix: Resolve type conversion error in node_api_create_property_key_utf16

refactor: Simplify node_api_create_property_key_utf16 implementation

lint

add node_api_create_property_key_utf16 property name

added doc for node_api_create_property_key_utf16

lint

lint

update napi doc for node_api_create_property_key_utf16

update: code snipet

test: added test for node_api_create_property_key_utf16

lint

lint

lint

call node_api_create_property_key_utf16

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

added TestPropertyKeyUtf16 napi_property_descriptor

lint doc

lint cpp

minor updates to PR nodejs#50282

feat: removed not used function for test

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>
mertcanaltin pushed a commit to mertcanaltin/node that referenced this pull request Dec 19, 2023
@anonrig @mhdawson @mertcanaltin
test: set test-structuredclone-* as flaky
df357c8 
PR-URL: nodejs#50261
Refs: nodejs#50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

meta: move Trott to TSC regular member

At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: nodejs#50297
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>

node-api: refactor napi set property function for improved performance

fix: lint

fix: lint

refactor: Improve performance by using internalized property keys

refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16

lint

lint

fix: Resolve compilation error in node_api_create_property_key_utf16

fix: Resolve type conversion error in node_api_create_property_key_utf16

refactor: Simplify node_api_create_property_key_utf16 implementation

lint

add node_api_create_property_key_utf16 property name

added doc for node_api_create_property_key_utf16

lint

lint

update napi doc for node_api_create_property_key_utf16

update: code snipet

test: added test for node_api_create_property_key_utf16

lint

lint

lint

call node_api_create_property_key_utf16

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update test/js-native-api/test_string/test_string.c

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <legendecas@gmail.com>

added TestPropertyKeyUtf16 napi_property_descriptor

lint doc

lint cpp

minor updates to PR nodejs#50282

feat: removed not used function for test

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>

Update doc/api/n-api.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-structuredclone-* as flaky
60b7b1f 
PR-URL: nodejs/node#50261
Refs: nodejs/node#50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-structuredclone-* as flaky
1ce3721 
PR-URL: nodejs/node#50261
Refs: nodejs/node#50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@H4ad H4ad H4ad approved these changes

@himself65 himself65 himself65 approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anonrig @nodejs-github-bot @StefanStojanovic @H4ad @himself65