Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: skip test-benchmark-os on IBMi #50286

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion benchmark/run.js
Expand Up @@ -3,6 +3,7 @@
const path = require('path');
const fork = require('child_process').fork;
const CLI = require('./_cli.js');
const os = require('os');

const cli = new CLI(`usage: ./node run.js [options] [--] <category> ...
Run each benchmark in the <category> directory a single time, more than one
Expand All @@ -18,7 +19,15 @@
matrix
all each benchmark category is run one after the other
`, { arrayArgs: ['set', 'filter', 'exclude'] });
const benchmarks = cli.benchmarks();
let benchmarks = cli.benchmarks();

Check failure on line 22 in benchmark/run.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md

'benchmarks' is never reassigned. Use 'const' instead

// IBMi does not have working uptime so don't try to run
// that benchmark
if (os.type() === 'OS400') {
const index = benchmarks.indexOf('os/uptime.js');
if (index != -1)

Check failure on line 28 in benchmark/run.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md

Expected '!==' and instead saw '!='
benchmarks.splice(index, 1);
}

if (benchmarks.length === 0) {
console.error('No benchmarks found');
Expand Down
3 changes: 0 additions & 3 deletions test/benchmark/benchmark.status
Expand Up @@ -20,6 +20,3 @@ prefix benchmark

[$arch==arm]

[$system==ibmi]
test-benchmark-os.js: SKIP