test_runner: Fix mock timer promisified setInterval return value #50331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
MoLow
approved these changes
Oct 22, 2023
mika-fischer
force-pushed
the
fix-50307
branch
from
78d949e
to
af38302
Compare
atlowChemi
approved these changes
Oct 23, 2023
atlowChemi
added
request-ci
github-actions
bot
removed
the
request-ci
mika-fischer
force-pushed
the
fix-50307
branch
2 times, most recently
from
02d7e2e
to
e65beea
Compare
MoLow
approved these changes
Oct 23, 2023
github-actions
bot
removed
the
request-ci
ErickWendel
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
LGTM. @mika-fischer congrats on your first PR on the nodejs repo!! It's really helpful!
|
@mika-fischer the PR needs a rebase |
promisified setInterval can be passed a value that is returned by the async iterable. The mocked promisified setInterval used this value for its own purposes. This brings the mocked version in line with the original. Fixes: nodejs#50307
Some tests relied on the custom return value and were broken by the change to always return the value provided by the caller.
mika-fischer
force-pushed
the
fix-50307
branch
from
e65beea
to
06d8b9d
Compare
Thanks @ErickWendel! |
done @MoLow |
github-actions
bot
removed
the
request-ci
|
I'm not sure why some tests are failing, these seem unrelated to the changes in this PR. Let me know if there's anything I can do to move this along. |
MoLow
added
the
commit-queue
27 tasks
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50331 ✔ Done loading data for nodejs/node/pull/50331 ----------------------------------- PR info ------------------------------------ Title test_runner: Fix mock timer promisified setInterval return value (#50331) Author Mika Fischer (@mika-fischer, first-time contributor) Branch mika-fischer:fix-50307 -> nodejs:main Labels author ready, needs-ci, commit-queue-squash, test_runner Commits 3 - test_runner: test return value of mocked promisified timers - test_runner: fix mock timer promisified setInterval return value - test_runner: fix mock timer setInterval tests Committers 1 - Mika Fischer PR-URL: https://github.com/nodejs/node/pull/50331 Reviewed-By: Moshe Atlow Reviewed-By: Chemi Atlow Reviewed-By: Erick Wendel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50331 Reviewed-By: Moshe Atlow Reviewed-By: Chemi Atlow Reviewed-By: Erick Wendel -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test_runner: test return value of mocked promisified timers ⚠ - test_runner: fix mock timer promisified setInterval return value ⚠ - test_runner: fix mock timer setInterval tests ℹ This PR was created on Sun, 22 Oct 2023 20:11:55 GMT ✔ Approvals: 3 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50331#pullrequestreview-1692229637 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/50331#pullrequestreview-1691892475 ✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/50331#pullrequestreview-1692276984 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-23T18:44:37Z: https://ci.nodejs.org/job/node-test-pull-request/55158/ - Querying data for job/node-test-pull-request/55158/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6632107907 |
benjamingr
approved these changes
Oct 24, 2023
16 tasks
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4f5db8b |
|
Did the closure of #50307 get dropped somehow? Should I have specified it differently? Should I close the issue now manually? |
|
Typically it needs Thank you for your contribution! |
20 tasks
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50331 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50331 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50331 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promisified setInterval can be passed a value that is returned by the async iterable. The mocked promisified setInterval used this value for its own purposes. This brings the mocked version in line with the original.