Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update OpenSSL to 3.0.12+quic1 #50411

Closed
wants to merge 2 commits into from
Closed

deps: update OpenSSL to 3.0.12+quic1 #50411

wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of OpenSSL to 3.0.12+quic1.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Oct 26, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau
Copy link
Member

For reference, this PR was generated by https://github.com/nodejs/node/actions/runs/6655826163/job/18086969161 (we should get the workflow to add this link to the PR).

richardlau
richardlau approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/55256/

I've canceled that run as it was started too early -- some of the platforms were only building the first commit (and the ones started later both commits).

We'll probably need #50395 to land first for the tests to pass on this version of OpenSSL.

@richardlau richardlau mentioned this pull request Oct 27, 2023
Closed
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2023
@richardlau
Copy link
Member

I've rebased this PR to pick up #50395 so the GitHub action runs can pass.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55275/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55277/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55278/

@richardlau richardlau added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 28, 2023
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Landed in d1592bd...116b28c

nodejs-github-bot added a commit that referenced this pull request Oct 28, 2023
@nodejs-github-bot
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
4281387 
PR-URL: #50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 29, 2023
Open
21 tasks
DylanTet pushed a commit to DylanTet/node that referenced this pull request Oct 29, 2023
@nodejs-github-bot @DylanTet
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
f80a1e7 
PR-URL: nodejs#50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
DylanTet pushed a commit to DylanTet/node that referenced this pull request Oct 29, 2023
@nodejs-github-bot @DylanTet
deps: update archs files for openssl-3.0.12+quic1
29f1c7b 
PR-URL: nodejs#50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 30, 2023
Open
Open
Open
@richardlau richardlau added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 1, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@nodejs-github-bot @alexfernandez
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
9078ccf 
PR-URL: nodejs#50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@nodejs-github-bot @alexfernandez
deps: update archs files for openssl-3.0.12+quic1
3499566 
PR-URL: nodejs#50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@baparham
Copy link

baparham commented Nov 7, 2023 •
edited

@richardlau @jasnell @RafaelGSS It seems reasonable that this upgrade should also be backported to 18.x since it is security related (albeit low, as already mentioned on the node.js blog post) so that it's in place for the next release cycle.

What's the process to run the openssl updater against older branches, or would it make sense to just do a manual cherry-pick of this commit to the 18.x branch? I see the lts-watch-v18.x label, but I'm not entirely sure what that does.

edit: I seem to have jumped the gun a bit before reading the backporting docs, so I found that the label does in fact mean that the releaser will have an eye on this PR to backport to 18.x when the time is right.

@RafaelGSS
Copy link
Member

When creating the v18 proposal it should be cherry-picked.

targos pushed a commit that referenced this pull request Nov 11, 2023
@nodejs-github-bot @targos
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
a64217c 
PR-URL: #50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@nodejs-github-bot @targos
deps: update archs files for openssl-3.0.12+quic1
a90c6d6 
PR-URL: #50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@targos targos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 15, 2023
targos pushed a commit that referenced this pull request Nov 15, 2023
@nodejs-github-bot @targos
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
3308189 
PR-URL: #50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 15, 2023
@nodejs-github-bot @targos
deps: update archs files for openssl-3.0.12+quic1
68cddd7 
PR-URL: #50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed lts-watch-v18.x PRs that may need to be released in v18.x. labels Nov 15, 2023
targos pushed a commit that referenced this pull request Nov 15, 2023
@nodejs-github-bot @targos
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
da26cdb 
PR-URL: #50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 15, 2023
@nodejs-github-bot @targos
deps: update archs files for openssl-3.0.12+quic1
3f6dcc6 
PR-URL: #50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 21, 2023
Merged
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
f8ac42e 
PR-URL: nodejs/node#50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: update archs files for openssl-3.0.12+quic1
1b391ba 
PR-URL: nodejs/node#50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
3ca3d76 
PR-URL: nodejs/node#50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: update archs files for openssl-3.0.12+quic1
7afcea5 
PR-URL: nodejs/node#50411
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. backported-to-v20.x PRs backported to the v20.x-staging branch. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nodejs-github-bot @richardlau @baparham @RafaelGSS @jasnell @panva @targos