Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in webstreams.md #50426

Merged
merged 1 commit into from Oct 27, 2023
Merged

doc: fix typo in webstreams.md #50426

merged 1 commit into from Oct 27, 2023

Conversation

andrefs
Copy link
Contributor

@andrefs andrefs commented Oct 27, 2023

Fixes minor typo in Webstreams documentation

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 27, 2023
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 27, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@benjamingr benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023
@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023
@aduh95 aduh95 merged commit 0a0b8df into nodejs:main Oct 27, 2023
25 of 26 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Oct 27, 2023

Landed in 0a0b8df, thanks for the contribution 🎉

@andrefs
Copy link
Contributor Author

andrefs commented Oct 27, 2023

Thanks, happy to help :)

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@andrefs @alexfernandez
doc: fix typo in webstreams.md
b34db0a 
PR-URL: nodejs#50426
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@andrefs @targos
doc: fix typo in webstreams.md
43074ee 
PR-URL: #50426
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@andrefs @UlisesGascon
doc: fix typo in webstreams.md
64bf2fd 
PR-URL: #50426
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@daeyeon daeyeon daeyeon approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andrefs @aduh95 @benjamingr @lpinca @daeyeon @nodejs-github-bot