Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix Writable.destroy performance regression #50478

Merged
merged 1 commit into from Oct 31, 2023
Merged

stream: fix Writable.destroy performance regression #50478

merged 1 commit into from Oct 31, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 30, 2023

PR-URL: #50409

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 30, 2023
@Trott Trott marked this pull request as ready for review October 30, 2023 20:11
@Trott Trott marked this pull request as draft October 30, 2023 20:11
@Trott
Copy link
Member Author

Trott commented Oct 30, 2023

This PR is here just to run the Coverage Linux (without intl) job using the same change in #50409 but against the current main branch to see if that succeeds where that PR has failed 4 times in a row.

@Trott Trott marked this pull request as ready for review October 30, 2023 23:14
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2023
@Trott Trott mentioned this pull request Oct 30, 2023
Closed
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 30, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55336/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55357/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55362/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2023
@Trott
Copy link
Member Author

Trott commented Oct 31, 2023

This is ready to land but needs one more approval.

ronag
ronag previously approved these changes Oct 31, 2023
View reviewed changes
@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/50478
✔  Done loading data for nodejs/node/pull/50478
----------------------------------- PR info ------------------------------------
Title      stream: fix Writable.destroy performance regression (#50478)
Author     Rich Trott  (@Trott)
Branch     Trott:test-pr -> nodejs:main
Labels     fast-track, author ready, needs-ci
Commits    1
 - stream: fix Writable.destroy performance regression
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/50478
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Robert Nagy 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50478
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Robert Nagy 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 30 Oct 2023 20:10:40 GMT
   ✔  Approvals: 2
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50478#pullrequestreview-1705323018
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/50478#pullrequestreview-1707190813
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-10-31T18:59:52Z: https://ci.nodejs.org/job/node-test-pull-request/55362/
- Querying data for job/node-test-pull-request/55362/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6712160359

@Trott Trott dismissed ronag’s stale review October 31, 2023 21:35

I'm going to dismiss this one because it's the commit author.

aduh95
aduh95 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss a bit of context on how this is perf related, but the change looks fine to me

@ronag @Trott
stream: fix Writable.destroy performance regression
c4decd7 
Ref: nodejs#50409
PR-URL: nodejs#50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott Trott merged commit c4decd7 into nodejs:main Oct 31, 2023
20 checks passed
@Trott
Copy link
Member Author

Trott commented Oct 31, 2023

Landed in c4decd7

@Trott Trott deleted the test-pr branch October 31, 2023 21:45
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Open
24 tasks
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@ronag @alexfernandez
stream: fix Writable.destroy performance regression
c2d2e0f 
Ref: nodejs#50409
PR-URL: nodejs#50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Nov 2, 2023
Open
Open
Open
Open
Open
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
@ronag @anonrig
stream: fix Writable.destroy performance regression
5c8de42 
Ref: nodejs#50409
PR-URL: nodejs#50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag @targos
stream: fix Writable.destroy performance regression
3674ad5 
Ref: #50409
PR-URL: #50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@ronag @targos
stream: fix Writable.destroy performance regression
360f5d9 
Ref: #50409
PR-URL: #50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@ronag @UlisesGascon
stream: fix Writable.destroy performance regression
6012e3e 
Ref: #50409
PR-URL: #50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@aduh95 aduh95 aduh95 approved these changes

@ronag ronag ronag left review comments

@mcollina mcollina Awaiting requested review from mcollina

@jasnell jasnell Awaiting requested review from jasnell

@benjamingr benjamingr Awaiting requested review from benjamingr

@rluvaton rluvaton Awaiting requested review from rluvaton

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Trott @nodejs-github-bot @ronag @H4ad @aduh95