Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing description of argument in subtle.encrypt #50578

Conversation

deokjinkim
Copy link
Contributor

@deokjinkim deokjinkim commented Nov 6, 2023

Description of third argument(data) in subtle.encrypt is missed, so add it.

subtle.encrypt(algorithm, key, data)

Description of third argument(data) in subtle.encrypt is missed,
so add it.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Nov 6, 2023
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 6, 2023
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 81a4a74 into nodejs:main Nov 8, 2023
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 81a4a74

targos pushed a commit that referenced this pull request Nov 11, 2023
Description of third argument(data) in subtle.encrypt is missed,
so add it.

PR-URL: #50578
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Nov 14, 2023
Description of third argument(data) in subtle.encrypt is missed,
so add it.

PR-URL: #50578
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
Description of third argument(data) in subtle.encrypt is missed,
so add it.

PR-URL: #50578
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants