Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: replace forEach() with for ... of #50595

Merged
merged 1 commit into from Nov 8, 2023
Merged

test_runner: replace forEach() with for ... of #50595

merged 1 commit into from Nov 8, 2023

Conversation

tomhaddad
Copy link
Contributor

@tomhaddad tomhaddad commented Nov 7, 2023 •
edited by marco-ippolito

Replaces usage of forEach() with for ... of in test-runner-mock-timers.js
#NodeConf

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@ljharb
Copy link
Member

ljharb commented Nov 7, 2023

why? assert.forEach isn’t the same as a for..of loop.

@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@tomhaddad tomhaddad force-pushed the test-runner-mock-timers-replace-foreach branch from 853f68e to 18bd8aa Compare November 7, 2023 15:23
@tomhaddad tomhaddad force-pushed the test-runner-mock-timers-replace-foreach branch from 18bd8aa to d907f14 Compare November 7, 2023 15:28
atlowChemi
atlowChemi reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@atlowChemi atlowChemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tomhaddad, what is the reason for this change?
This is not a part of core in which we avoid prototype calls like forEach()

@lpinca
Copy link
Member

lpinca commented Nov 7, 2023 •
edited

@atlowChemi it's a code-and-learn exercise.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55487/

@ljharb
Copy link
Member

ljharb commented Nov 7, 2023

That doesn’t mean the change should just land tho, right? Or does it mean the PR isn’t going to actually land, it’s just to demonstrate how to do one?

@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Open
16 tasks
aduh95
aduh95 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: this is a test file, we do not have any requirements for how to iterate over arrays in test files, both methods are fine by me.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55491/

@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2023

That doesn’t mean the change should just land tho, right? Or does it mean the PR isn’t going to actually land, it’s just to demonstrate how to do one?

As any PR, this can land after if it has approval and green CI, after the waiting time. Code and Learn consists on making low hanging fruit PRs to get a first contribution to the repo, with the hope that it will result in more contributions in the future.

Thanks for the PR @tomhaddad :)

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2023
@tomhaddad
Copy link
Contributor Author

Thanks for the PR @tomhaddad :)

You are most welcome, happy to have made my first contribution :)

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Fast-track has been requested by @aduh95. Please 👍 to approve.

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8588ee1 into nodejs:main Nov 8, 2023
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8588ee1

@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Open
20 tasks
This was referenced Nov 10, 2023
Open
Open
targos pushed a commit that referenced this pull request Nov 11, 2023
@tomhaddad @targos
test_runner: replace forEach with for of
992ad0d 
PR-URL: #50595
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@github-actions github-actions bot mentioned this pull request Nov 12, 2023
Open
18 tasks
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@tomhaddad @targos
test_runner: replace forEach with for of
ae4a7ba 
PR-URL: #50595
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@tomhaddad @UlisesGascon
test_runner: replace forEach with for of
c33a84a 
PR-URL: #50595
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi left review comments

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@tomhaddad @nodejs-github-bot @ljharb @lpinca @aduh95 @benjamingr @MoLow @atlowChemi @marco-ippolito