test: replace forEach with for of #50597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
marco-ippolito
approved these changes
Nov 7, 2023
marco-ippolito
added
the
code-and-learn
jabali2004
force-pushed
the
chore/convert-forEach-to-forOf
branch
from
1a345e3
to
b990ef5
Compare
lpinca
approved these changes
Nov 7, 2023
github-actions
bot
removed
the
request-ci
16 tasks
tniessen
approved these changes
Nov 8, 2023
tniessen
added
the
author ready
This was referenced Nov 9, 2023
debadree25
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 38cd4f7 |
27 tasks
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50597 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
18 tasks
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
PR-URL: #50597 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50597 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced forEach with for of in test/parralel/test-crypto-getcipherinfo.js
#NodeConfEU