doc: update Crypto API doc for x509.keyUsage to x509.extKeyUsage #50603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
marco-ippolito
added
the
code-and-learn
github-actions
bot
removed
the
request-ci
This was referenced Nov 8, 2023
This was referenced Nov 10, 2023
jasnell
approved these changes
Nov 11, 2023
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50603 ✔ Done loading data for nodejs/node/pull/50603 ----------------------------------- PR info ------------------------------------ Title doc: update Crypto API doc for x509.keyUsage to x509.extKeyUsage (#50603) Author Daniel Meechan (@DMeechan, first-time contributor) Branch DMeechan:crypto-api-key-usage -> nodejs:main Labels crypto, doc, code-and-learn Commits 1 - doc: update Crypto API doc for x509.keyUsage Committers 1 - Daniel Meechan PR-URL: https://github.com/nodejs/node/pull/50603 Refs: https://github.com/nodejs/node/issues/48727 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50603 Refs: https://github.com/nodejs/node/issues/48727 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 07 Nov 2023 15:15:49 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50603#pullrequestreview-1726076103 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✘ This PR needs to wait 71 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6835039755 |
18 tasks
marco-ippolito
approved these changes
Nov 20, 2023
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a9a4778 |
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
PR-URL: nodejs#50603 Refs: nodejs#48727 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
PR-URL: nodejs#50603 Refs: nodejs#48727 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Crypto API definition for
x509.keyUsagetox509.extKeyUsage.Refs: #48727
Created at NodeConf! ❤️