Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach() with for ... of in test-readline-keys.js #50604

Merged
merged 1 commit into from Nov 11, 2023
Merged

test: replace forEach() with for ... of in test-readline-keys.js #50604

merged 1 commit into from Nov 11, 2023

Conversation

WillLiang918
Copy link
Contributor

NodeConf

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2023 •
edited by jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/55525/ 💛

@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8af570a into nodejs:main Nov 11, 2023
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8af570a

targos pushed a commit that referenced this pull request Nov 11, 2023
@WillLiang918 @targos
test: replace forEach() with for ... of in test-readline-keys.js
8ade980 
PR-URL: #50604
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@WillLiang918 @targos
test: replace forEach() with for ... of in test-readline-keys.js
e978fd4 
PR-URL: #50604
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@WillLiang918 @UlisesGascon
test: replace forEach() with for ... of in test-readline-keys.js
9397b2d 
PR-URL: #50604
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@WillLiang918 @nodejs-github-bot @jasnell @lpinca @marco-ippolito