test: replace forEach in whatwg-encoding-custom-interop #50607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
marco-ippolito
added
the
code-and-learn
tniessen
approved these changes
Nov 7, 2023
lpinca
approved these changes
Nov 10, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50607 ✔ Done loading data for nodejs/node/pull/50607 ----------------------------------- PR info ------------------------------------ Title test: replace forEach in whatwg-encoding-custom-interop (#50607) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch HonzaMac:feature/replace-foreach-in-interop -> nodejs:main Labels test, code-and-learn, needs-ci Commits 1 - test: replace forEach in whatwg-encoding-custom-interop Committers 1 - Jan Machala PR-URL: https://github.com/nodejs/node/pull/50607 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50607 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 07 Nov 2023 15:23:28 GMT ✔ Approvals: 2 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/50607#pullrequestreview-1718007820 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50607#pullrequestreview-1725269329 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6828012526 |
github-actions
bot
removed
the
request-ci
27 tasks
jasnell
approved these changes
Nov 11, 2023
This was referenced Nov 12, 2023
tniessen
removed
the
commit-queue-failed
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 96890f6 |
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
PR-URL: #50607 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
PR-URL: nodejs#50607 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
PR-URL: nodejs#50607 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 29, 2023
PR-URL: #50607 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 30, 2023
PR-URL: #50607 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50607 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
PR-URL: #50607 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced forEach with for of in
test/parallel/test-whatwg-encoding-custom-interop.js.#nodeConfEu