Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix JSONParser leaking internal V8 scopes #50688

Merged
merged 1 commit into from
Nov 14, 2023
Merged

src: fix JSONParser leaking internal V8 scopes #50688

merged 1 commit into from
Nov 14, 2023

Commits on Nov 12, 2023

  1. src: fix JSONParser leaking internal V8 scopes 

    JSONParser uses V8's JSON.parse (for now), meaning that its uses handles
and contexts. JSONParser was leaking its internal HandleScope and
Context::Scope.

Move the scope construction to the member functions to prevent those
scopes from leaking.

Refs: nodejs#50680 (comment)
    @kvakil
    kvakil committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    bc466e6 View commit details
    Browse the repository at this point in the history