test: improve test-bootstrap-modules.js #50708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in nodejs#45662.
joyeecheung
force-pushed
the
bootstrap-module-test
branch
from
e4380c4
to
5741905
Compare
github-actions
bot
removed
the
request-ci
legendecas
reviewed
Nov 13, 2023
| // the two stages for them. | ||
| const expected = {}; | ||
|
|
||
| expected.beforePreExec = new Set([ |
There was a problem hiding this comment.
To clearly indicate that these modules were executed at build time, I would find a name like atStartupSnapshot or atBuildTime, to be more intuitive as contradicting atRunTime.
There was a problem hiding this comment.
I thought about that but it seems weird until workers do load builtins into the snapshot (which was what I was working on originally). For now it seems less weird to call it beforePreExec which is still factually correct. But I am also okay with using atStartupSnapshot and add a note saying that this is not factually correct for workers yet (or it's never factually correct for cross-compiled builds before we make snapshot support work for them)
This was referenced Nov 14, 2023
aduh95
reviewed
Nov 15, 2023
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Nov 16, 2023
richardlau
approved these changes
Nov 16, 2023
anonrig
approved these changes
Nov 17, 2023
github-actions
bot
removed
the
request-ci
aduh95
added
the
author ready
legendecas
approved these changes
Nov 17, 2023
joyeecheung
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50708 ✔ Done loading data for nodejs/node/pull/50708 ----------------------------------- PR info ------------------------------------ Title test: improve test-bootstrap-modules.js (#50708) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:bootstrap-module-test -> nodejs:main Labels test, author ready, needs-ci Commits 2 - test: improve test-bootstrap-modules.js - fixup! test: improve test-bootstrap-modules.js #50708 Committers 2 - Joyee Cheung - GitHub PR-URL: https://github.com/nodejs/node/pull/50708 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50708 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 13 Nov 2023 13:10:44 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50708#pullrequestreview-1733682030 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50708#pullrequestreview-1734416571 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50708#pullrequestreview-1737180743 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50708#pullrequestreview-1737350580 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-11-17T16:08:59Z: https://ci.nodejs.org/job/node-test-pull-request/55712/ - Querying data for job/node-test-pull-request/55712/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50708 From https://github.com/nodejs/node * branch refs/pull/50708/merge -> FETCH_HEAD ✔ Fetched commits as ce4642a5c2ac..1cc16d5329ac -------------------------------------------------------------------------------- Auto-merging test/parallel/test-bootstrap-modules.js [main 5e27c443ab] test: improve test-bootstrap-modules.js Author: Joyee Cheung Date: Sun Nov 12 22:38:30 2023 +0100 1 file changed, 103 insertions(+), 25 deletions(-) Auto-merging test/parallel/test-bootstrap-modules.js [main 562733ba5b] fixup! test: improve test-bootstrap-modules.js #50708 Author: Joyee Cheung Date: Wed Nov 15 15:40:27 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/6909048350 |
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0e24f91 |
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in #45662. PR-URL: #50708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in nodejs#45662. PR-URL: nodejs#50708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in nodejs#45662. PR-URL: nodejs#50708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 29, 2023
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in #45662. PR-URL: #50708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 30, 2023
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in #45662. PR-URL: #50708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in #45662. PR-URL: #50708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in. This helps preventing regressions like the one reported in #45662. PR-URL: #50708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divide builtins into two lists depending on whether they are loaded before pre-execution or at run time, and give clearer suggestions about how to deal with them based on the category they are in.
This helps preventing regressions like the one reported in #45662.