src: remove erroneous default argument in RadixTree

[tniessen]

This default argument can never benefit any potential caller because any call site that occurs after this definition will result in a compiler error due to RadixTree::Lookup(const std::string_view&) now being an ambiguous call target.

The original unambiguous definition is this:

node/src/permission/fs_permission.h

Lines 129 to 130 in 59a9e49

	bool Lookup(const std::string_view& s) { return Lookup(s, false); }
	bool Lookup(const std::string_view& s, bool when_empty_return);

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg

[RafaelGSS]

Good catch. I forgot to remove it on the last update.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55669/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/50736
✔  Done loading data for nodejs/node/pull/50736
----------------------------------- PR info ------------------------------------
Title      src: remove erroneous default argument in RadixTree (#50736)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:src-perm-erroneous-default-value -> nodejs:main
Labels     c++, author ready, needs-ci
Commits    1
 - src: remove erroneous default argument in RadixTree
Committers 1
 - Tobias Nießen 
PR-URL: https://github.com/nodejs/node/pull/50736
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50736
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 15 Nov 2023 00:45:47 GMT
   ✔  Approvals: 3
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50736#pullrequestreview-1731124346
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50736#pullrequestreview-1732136211
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50736#pullrequestreview-1733010137
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-15T20:42:40Z: https://ci.nodejs.org/job/node-test-pull-request/55669/
- Querying data for job/node-test-pull-request/55669/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   d1326e5b54..09c3bb15d7  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - e1de547880 permission: mark const functions as such
 - 09c3bb15d7 permission: mark const functions as such
--------------------------------------------------------------------------------
HEAD is now at 09c3bb15d7 permission: mark const functions as such
   ✔  Reset to origin/main
- Downloading patch for 50736
From https://github.com/nodejs/node
 * branch                  refs/pull/50736/merge -> FETCH_HEAD
✔  Fetched commits as d1326e5b54f7..b2b31398d31c
--------------------------------------------------------------------------------
Auto-merging src/permission/fs_permission.cc
CONFLICT (content): Merge conflict in src/permission/fs_permission.cc
error: could not apply b2b31398d3... src: remove erroneous default argument in RadixTree
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/6903699999

[tniessen]

Rebased, so needs another CI run and re-approval.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55714/

[nodejs-github-bot]

Landed in 2059913