Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: clarify nomination process according to Node.js charter #50834

Merged
merged 4 commits into from
Nov 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,9 @@ Provide a summary of the nominee's contributions. For example:
Mention @nodejs/collaborators in the issue to notify other collaborators about
the nomination.

The nomination passes if no collaborators oppose it after one week. Otherwise,
the nomination fails.
The nomination passes if no collaborators oppose it after one week. In the case
of an objection, the TSC is responsible for working with the individuals
involved and finding a resolution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
involved and finding a resolution.
involved and finding a resolution. The TSC may, at its discretion, vote to override
any objection but should do so only after other measures to reach consensus have
failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the existing phrasing since it says the TSC is responsible for resolving the matter rather than just voting. The TSC for example can come to consensus about overriding a nomination without voting. It also emphasizes the TSC working with the individuals rather than them having to reach consensus on their own.


There are steps a nominator can take in advance to make a nomination as
frictionless as possible. To request feedback from other collaborators in
Expand Down