Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update email to reflect affiliation #50856

Merged
merged 3 commits into from Nov 24, 2023
Merged

doc: update email to reflect affiliation #50856

merged 3 commits into from Nov 24, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 22, 2023

Updating my email address on README to reflect my affiliation with Sentry (https://sentry.io). They're sponsoring my work to Node.js starting from November 20.

cc @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 22, 2023
aduh95
aduh95 reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to also change the MAILMAP so your previous commit can still be attributed to you – otherwise the bot will open a PR to remove you from collaborators as soon as this is merged 😅

mcollina
mcollina approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig
Copy link
Member Author

anonrig commented Nov 22, 2023

You'd need to also change the MAILMAP so your previous commit can still be attributed to you – otherwise the bot will open a PR to remove you from collaborators as soon as this is merged 😅

I updated .mailmap as well. Can you validate @aduh95?

@aduh95
Copy link
Contributor

aduh95 commented Nov 22, 2023

You can validate by running git log -1 --format=%aE <some-hash-of-a-commit-made-with-your-previous-address:

$ git fetch https://github.com/nodejs/node.git main && git reset FETCH_HEAD --hard
$ git log -1 --format=%aE 4cfc188f872ba766f6e1a019165e1cd428a9f6cb
yagiz@nizipli.com
$ curl -L https://github.com/nodejs/node/pull/50856.patch | git am
$ git log -1 --format=%aE 4cfc188f872ba766f6e1a019165e1cd428a9f6cb
yagiz@nizipli.com

As you can see, the mailmap is backward: it maps all the commits to your personal address, and none to your Sentry one.

aduh95
aduh95 reviewed Nov 23, 2023
View reviewed changes
.mailmap Outdated Show resolved Hide resolved
@anonrig @aduh95
Update .mailmap
221a4af 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 23, 2023
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 41e225c into nodejs:main Nov 24, 2023
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 41e225c

martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@anonrig @martenrichter
doc: update email to reflect affiliation
d7fa0d7 
PR-URL: nodejs#50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@anonrig @lucshi
doc: update email to reflect affiliation
33009c7 
PR-URL: nodejs#50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @RafaelGSS
doc: update email to reflect affiliation
02a963e 
PR-URL: #50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@anonrig @RafaelGSS
doc: update email to reflect affiliation
6485687 
PR-URL: #50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@anonrig @RafaelGSS
doc: update email to reflect affiliation
2a6f9e3 
PR-URL: #50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@anonrig @UlisesGascon
doc: update email to reflect affiliation
76942c0 
PR-URL: #50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@anonrig @UlisesGascon
doc: update email to reflect affiliation
af5b726 
PR-URL: #50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@anonrig @UlisesGascon
doc: update email to reflect affiliation
45ff564 
PR-URL: #50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@anonrig @UlisesGascon
doc: update email to reflect affiliation
fe31505 
PR-URL: #50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@mcollina mcollina mcollina approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@anonrig @aduh95 @nodejs-github-bot @mcollina @ruyadorno @jasnell @lpinca