Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick de611e69ad51 #51200

Merged
merged 1 commit into from
Dec 21, 2023

Commits on Dec 19, 2023

  1. deps: V8: cherry-pick de611e69ad51

    Original commit message:
    
        [maglev] fix non-ptr-compr compilation on old compilers
    
        When pointer compression is disabled, the preprocessor expands some
        static asserts to static_assert(false), which doesn't compile on
        compilers not implementing the C++ defect report CWG2518, notably clang
        before version 17 and gcc before version 13.
    
        Adding in part of the template parameter to the static assert prevents
        it from being evaluated immediately which fixes the compilation.
    
        Test: compiled with gcc-11 and clang-14 without pointer compression.
        Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59
        Fixed: v8:14355
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Commit-Queue: Leszek Swirski <leszeks@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#91553}
    
    Refs: v8/v8@de611e6
    kvakil committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5f78ed1 View commit details
    Browse the repository at this point in the history