build, tools: copy release assets to staging R2 bucket once built #51394

flakey5 · 2024-01-06T21:42:33Z

cc @MoLow @targos

flakey5 · 2024-01-06T21:43:05Z

Background: nodejs/build#3602

Makefile

vcbuild.bat

tools/release.sh

vcbuild.bat

targos · 2024-01-21T18:04:26Z

I did a test release build (https://ci-release.nodejs.org/job/iojs+release/9917/ for those who have access), but it failed to upload:

09:07:10 ssh node-www "aws s3 cp nodejs/custom/v22.0.0-test2024012187d2b3c18f/node-v22.0.0-test2024012187d2b3c18f-linux-x64.tar.gz s3://dist-staging/nodejs/custom/v22.0.0-test2024012187d2b3c18f/node-v22.0.0-test2024012187d2b3c18f-linux-x64.tar.gz --endpoint=https://07be8d2fbc940503ca1be344714cb0d1.r2.cloudflarestorage.com/" --profile=nodejs-r2-dist-bucket
09:07:12 
09:07:12 The config profile (nodejs-r2-dist-bucket) could not be found
09:07:12 make: *** [Makefile:1291: binary-upload] Error 255

flakey5 · 2024-01-22T21:40:59Z

I did a test release build (https://ci-release.nodejs.org/job/iojs+release/9917/ for those who have access), but it failed to upload:

Should be the correct profile now (or at least this is the profile used here https://github.com/nodejs/build/blob/a721695e2b652bee056502e5c7da3ec03d1ca150/ansible/www-standalone/tools/promote/settings#L41)

targos · 2024-01-23T07:39:44Z

New build: https://ci-release.nodejs.org/job/iojs+release/9924/

targos · 2024-01-23T08:33:50Z

It looks much better:

There are a few failures, but I'll report them all when the job is finished.

targos · 2024-01-23T15:58:36Z

On Windows (all three builds):

upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-arm64.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-arm64.msi
09:47:52 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-arm64.zip.done': No such file or directory

upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x64.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x64.msi
09:17:15 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-x64.zip.done': No such file or directory

upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x86.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x86.msi
09:19:02 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-x86.zip.done': No such file or directory

On macOS (osx11-release-pkg)

09:33:01 scp -p node-v22.0.0-test20240123a1b77670ae.pkg node-www:nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg
09:33:06 ssh node-www "aws s3 cp nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg --endpoint=https://07be8d2fbc940503ca1be344714cb0d1.r2.cloudflarestorage.com/" --profile=worker"
09:33:06 /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
09:33:06 /bin/sh: -c: line 1: syntax error: unexpected end of file
09:33:06 make: *** [pkg-upload] Error 2

vcbuild.bat

targos · 2024-01-24T16:17:37Z

please review each new line in the Makefile. The double quotes are not placed correctly.

Makefile

nodejs-github-bot · 2024-05-05T08:41:06Z

Commit Queue failed

- Loading data for nodejs/node/pull/51394
✔  Done loading data for nodejs/node/pull/51394
----------------------------------- PR info ------------------------------------
Title      build, tools: copy release assets to staging R2 bucket once built (#51394)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     flakey5:flakey5/nodejs/build/3602 -> nodejs:main
Labels     windows, build, tools, needs-ci, commit-queue-squash
Commits    2
 - build, tools: copy release assets to staging R2 bucket once built
 - Update tools/release.sh
Committers 1
 - flakey5 <73616808+flakey5@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/51394
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51394
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 06 Jan 2024 21:42:33 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/51394#pullrequestreview-2014829830
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51394#pullrequestreview-2014852122
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51394#pullrequestreview-2018841776
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8956985975

targos · 2024-05-05T09:05:03Z

I want to land #45427 first as it's building a whole new ccache.

nodejs-github-bot · 2024-05-05T14:55:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58959/

targos · 2024-05-05T20:15:03Z

@flakey5 Can you please rebase on the latest main? It seems that the CI wrongly sets the major version as 22 instead of 23.

flakey5 · 2024-05-05T22:29:31Z

Done

Co-authored-by: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot · 2024-05-06T04:39:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58974/

nodejs-github-bot · 2024-05-06T05:49:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58975/

nodejs-github-bot · 2024-05-06T07:42:33Z

Landed in e5a76f1

Note: nodejs/node#51394 should land before this does Reference nodejs#3602

Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Jan 6, 2024

flakey5 mentioned this pull request Jan 6, 2024

Upload dist assets to a staging R2 bucket before a release is promoted nodejs/build#3602

Open

4 tasks

targos reviewed Jan 7, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

flakey5 force-pushed the flakey5/nodejs/build/3602 branch from 5bcb9ce to d716fb0 Compare January 8, 2024 00:31

targos reviewed Jan 8, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

targos reviewed Jan 8, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

targos reviewed Jan 8, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

targos reviewed Jan 8, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

targos reviewed Jan 8, 2024

View reviewed changes

vcbuild.bat Outdated Show resolved Hide resolved

flakey5 force-pushed the flakey5/nodejs/build/3602 branch from 7a883e3 to 2da0546 Compare January 10, 2024 21:34

targos reviewed Jan 11, 2024

View reviewed changes

vcbuild.bat Outdated Show resolved Hide resolved

flakey5 force-pushed the flakey5/nodejs/build/3602 branch from 2da0546 to 9a7c146 Compare January 17, 2024 20:35

targos reviewed Jan 18, 2024

View reviewed changes

tools/release.sh Show resolved Hide resolved

targos reviewed Jan 18, 2024

View reviewed changes

vcbuild.bat Outdated Show resolved Hide resolved

flakey5 force-pushed the flakey5/nodejs/build/3602 branch 2 times, most recently from 85f98db to 87d2b3c Compare January 19, 2024 20:42

flakey5 force-pushed the flakey5/nodejs/build/3602 branch from 87d2b3c to a1b7767 Compare January 22, 2024 21:40

targos reviewed Jan 24, 2024

View reviewed changes

vcbuild.bat Show resolved Hide resolved

flakey5 force-pushed the flakey5/nodejs/build/3602 branch from a1b7767 to 4d453df Compare January 24, 2024 20:21

targos reviewed Jan 26, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 5, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 5, 2024

MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 5, 2024

targos removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024

targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024

flakey5 force-pushed the flakey5/nodejs/build/3602 branch from 7121813 to 33c6584 Compare May 5, 2024 22:29

build, tools: copy release assets to staging R2 bucket once built

2ee2b5f

Co-authored-by: Michaël Zasso <targos@protonmail.com>

flakey5 force-pushed the flakey5/nodejs/build/3602 branch from 33c6584 to 2ee2b5f Compare May 5, 2024 23:13

targos approved these changes May 6, 2024

View reviewed changes

targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024

nodejs-github-bot merged commit e5a76f1 into nodejs:main May 6, 2024
56 checks passed

flakey5 added a commit to flakey5/nodejs-build that referenced this pull request May 6, 2024

ansible: promote release assets from staging r2 bucket

84fccff

Note: nodejs/node#51394 should land before this does Reference nodejs#3602

targos mentioned this pull request May 13, 2024

v22.2.0 release proposal #52971

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build, tools: copy release assets to staging R2 bucket once built #51394

build, tools: copy release assets to staging R2 bucket once built #51394

flakey5 commented Jan 6, 2024 •

edited

flakey5 commented Jan 6, 2024

targos commented Jan 21, 2024

flakey5 commented Jan 22, 2024 •

edited

targos commented Jan 23, 2024

targos commented Jan 23, 2024

targos commented Jan 23, 2024

targos commented Jan 24, 2024

nodejs-github-bot commented May 5, 2024

targos commented May 5, 2024

nodejs-github-bot commented May 5, 2024

targos commented May 5, 2024

flakey5 commented May 5, 2024

nodejs-github-bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024

build, tools: copy release assets to staging R2 bucket once built #51394

build, tools: copy release assets to staging R2 bucket once built #51394

Conversation

flakey5 commented Jan 6, 2024 • edited

flakey5 commented Jan 6, 2024

targos commented Jan 21, 2024

flakey5 commented Jan 22, 2024 • edited

targos commented Jan 23, 2024

targos commented Jan 23, 2024

targos commented Jan 23, 2024

On macOS (osx11-release-pkg)

targos commented Jan 24, 2024

nodejs-github-bot commented May 5, 2024

targos commented May 5, 2024

nodejs-github-bot commented May 5, 2024

targos commented May 5, 2024

flakey5 commented May 5, 2024

nodejs-github-bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024

flakey5 commented Jan 6, 2024 •

edited

flakey5 commented Jan 22, 2024 •

edited