Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: update iterations of benchmark/assert/deepequal-map.js #51416

Merged

Conversation

lucshi
Copy link
Contributor

@lucshi lucshi commented Jan 10, 2024

Fixed: #50571

Before applying this PR, the top functions are reading test JS file, instead of real logic code of "equal".
After increasing the iteration value, the test case behaved as expected to trigger equal.

Below is the benefit after changing the iteration value. Now it reflects the real performance but brought no much overhead on execution duration.

<style> </style>
      after PR before PR benefit
assert/deepequal-map.js method="deepEqual_primitiveOnly" strict=0 59545.18483 34260.41796 174%
assert/deepequal-map.js method="deepEqual_objectOnly" strict=0 3638.474777 3392.21504 107%
assert/deepequal-map.js method="deepEqual_mixed" strict=0 6454.155549 5799.864942 111%
assert/deepequal-map.js method="notDeepEqual_primitiveOnly" strict=0 102229.4693 47497.09769 215%
assert/deepequal-map.js method="notDeepEqual_objectOnly" strict=0 6720.715593 6003.967109 112%
assert/deepequal-map.js method="notDeepEqual_mixed" strict=0 794615.0527 348783.2696 228%
assert/deepequal-map.js method="deepEqual_primitiveOnly" strict=1 56371.15599 34136.76485 165%
assert/deepequal-map.js method="deepEqual_objectOnly" strict=1 3605.96319 3395.947981 106%
assert/deepequal-map.js method="deepEqual_mixed" strict=1 7022.193813 6173.548626 114%
assert/deepequal-map.js method="notDeepEqual_primitiveOnly" strict=1 101741.2196 48439.2862 210%
assert/deepequal-map.js method="notDeepEqual_objectOnly" strict=1 6150.376161 5650.374937 109%
assert/deepequal-map.js method="notDeepEqual_mixed" strict=1 644760.3742 337935.3367 191%

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jan 10, 2024
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6c080f6 into nodejs:main Feb 28, 2024
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6c080f6

@lucshi lucshi deleted the benchmark/assert/deepequal-map.js branch February 29, 2024 01:14
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
Fixed: #50571
PR-URL: #51416
Fixes: #50571
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
Fixed: #50571
PR-URL: #51416
Fixes: #50571
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Fixed: #50571
PR-URL: #51416
Fixes: #50571
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Fixed: #50571
PR-URL: #51416
Fixes: #50571
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
Fixed: nodejs#50571
PR-URL: nodejs#51416
Fixes: nodejs#50571
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes
3 participants