Revert 51255 #51491

mcollina · 2024-01-16T16:01:48Z

Reverts #51255
Fixes #51486

Adds a regression test.

This reverts commit 4d3923a.

Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2024-01-16T16:07:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56815/

mcollina · 2024-01-16T17:15:35Z

Can we fast-track this?

github-actions · 2024-01-16T17:15:52Z

Fast-track has been requested by @mcollina. Please 👍 to approve.

nodejs-github-bot · 2024-01-17T09:40:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56818/

RafaelGSS · 2024-01-18T13:26:23Z

@nodejs/tsc @nodejs/build I was planning to create a proposal yesterday with this revert but apparently some of our machines are suffering. Is that ok to force land it? I'm planning to create the proposal asap and release it tomorrow.

Considering it's a clean revert + a test case it wouldn't be a problem I assume.

cc: @nodejs/releasers

aduh95 · 2024-01-18T14:02:53Z

apparently some of our machines are suffering

The issue seems to be the backlog for the osx CI is growing faster than the CI is eating it. Would it be possible to disable that job until the queue is gone instead?

nodejs-github-bot · 2024-01-18T14:03:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56833/

BethGriggs · 2024-01-18T15:01:00Z

The issue seems to be the backlog for the osx CI is growing faster than the CI is eating it. Would it be possible to disable that job until the queue is gone instead?

All the osx11-x64 machines are offline https://ci.nodejs.org/label/osx11-x64/

nodejs-github-bot · 2024-01-18T15:53:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56836/

nodejs-github-bot · 2024-01-19T09:54:31Z

Commit Queue failed

- Loading data for nodejs/node/pull/51491
✔  Done loading data for nodejs/node/pull/51491
----------------------------------- PR info ------------------------------------
Title      Revert 51255 (#51491)
Author     Matteo Collina  (@mcollina)
Branch     mcollina:revert-51255 -> nodejs:main
Labels     fast-track, commit-queue-rebase
Commits    2
 - Revert "stream: fix cloned webstreams not being unref'd"
 - test: add regression test for 51586
Committers 1
 - Matteo Collina 
PR-URL: https://github.com/nodejs/node/pull/51491
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matthew Aitken 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51491
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matthew Aitken 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 16 Jan 2024 16:01:48 GMT
   ✔  Approvals: 7
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51491#pullrequestreview-1824043243
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51491#pullrequestreview-1824108380
   ✔  - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/51491#pullrequestreview-1824177345
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/51491#pullrequestreview-1824440897
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51491#pullrequestreview-1824680016
   ✔  - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/51491#pullrequestreview-1826347736
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/51491#pullrequestreview-1830226110
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-01-18T15:53:59Z: https://ci.nodejs.org/job/node-test-pull-request/56836/
- Querying data for job/node-test-pull-request/56836/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/7582152963

nodejs-github-bot · 2024-01-19T10:39:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56840/

nodejs-github-bot · 2024-01-19T11:47:08Z

Landed in a772973...fbf1fb3

This reverts commit 4d3923a. PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This reverts commit 4d3923a. PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

This reverts commit 4d3923a. PR-URL: nodejs#51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

lib/internal/webstreams/readablestream.js

@@ -598,8 +598,6 @@ class ReadableStream {

  [kTransferList]() {
    const { port1, port2 } = new MessageChannel();
-    port1.unref();
