Commits on Jan 25, 2024

1. inspector: add NodeRuntime.waitingForDebugger event …

   `NodeRuntime.waitingForDebugger` is a new Inspector Protocol event that
   will fire when the process being inspected is waiting for the debugger
   (for example, when `inspector.waitForDebugger()` is called). This allows
   inspecting processes to know when the inspected process is waiting for a
   `Runtime.runIfWaitingForDebugger` message to resume execution. It allows
   tooling to resume execution of the inspected process as soon as it deems
   necessary, without having to guess if the inspected process is waiting
   or not, making the workflow more deterministic. With a more
   deterministic workflow, it is possible to update Node.js core tests to
   avoid race conditions that can cause flakiness. Therefore, tests were
   also changed as following:
   
     * Remove no-op Runtime.runIfWaitingForDebugger from tests that don't
       need it
     * Use NodeRuntime.waitingForDebugger in all tests that need
       Runtime.runIfWaitingForDebugger, to ensure order of operations is
       predictable and correct
     * Simplify test-inspector-multisession-ws
   
   There might be value in adding `NodeWorker.waitingForDebugger` in a
   future patch, but as of right now, no Node.js core inspector tests using
   worker threads are not failing due to race conditions.
   
   Fixes: nodejs#34730

   

   mmarchini committed Jan 25, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9ec34cb
   • Browse repository at this point

   Copy the full SHA

   9ec34cb View commit details

   Browse the repository at this point in the history