Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove test-crypto-keygen flaky designation #51567

Merged

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 25, 2024

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 25, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca force-pushed the remove/flaky-test-crypto-keygen branch from 4af2580 to 53ee8e3 Compare February 1, 2024 20:28
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 3, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2024
@nodejs-github-bot nodejs-github-bot merged commit 415aa77 into nodejs:main Feb 3, 2024
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 415aa77

@lpinca lpinca deleted the remove/flaky-test-crypto-keygen branch February 3, 2024 09:43
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
Refs: nodejs#41206 (comment)
PR-URL: nodejs#51567
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
Refs: #41206 (comment)
PR-URL: #51567
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
Refs: nodejs#41206 (comment)
PR-URL: nodejs#51567
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Refs: #41206 (comment)
PR-URL: #51567
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Refs: #41206 (comment)
PR-URL: #51567
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants