Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build: workaround for node-core-utils" #51975

Merged
merged 1 commit into from Mar 5, 2024
Merged

Revert "build: workaround for node-core-utils" #51975

merged 1 commit into from Mar 5, 2024

Conversation

richardlau
Copy link
Member

This reverts commit b2a6083.

The auto-start-ci workflow is currently broken by the latest node-core-utils. e.g.
https://github.com/nodejs/node/actions/runs/8158770866/job/22301449831#step:6:17 (note the workflow passed but failed to start any CIs)

/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507
  ReadableStream
  ^

ReferenceError: ReadableStream is not defined
    at Object.<anonymous> (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507:3)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:[18](https://github.com/nodejs/node/actions/runs/8158770866/job/22301449831#step:6:19))
    at Object.<anonymous> (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/index.js:11:5)
    at Module._compile (node:internal/modules/cjs/loader:1[19](https://github.com/nodejs/node/actions/runs/8158770866/job/22301449831#step:6:20)8:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1[25](https://github.com/nodejs/node/actions/runs/8158770866/job/22301449831#step:6:26)2:10)

From @targos in Slack:

The workflow should be updated, Node.js 16 support was removed in https://github.com/nodejs/node-core-utils/releases/tag/v4.0.0
Also node-fetch was removed by https://github.com/nodejs/node-core-utils/pull/666/files

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 5, 2024
Trott
Trott approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 5a967a8 into main Mar 5, 2024
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5a967a8

@nodejs-github-bot nodejs-github-bot deleted the fix-auto-start-ci branch March 5, 2024 16:52
targos pushed a commit that referenced this pull request Mar 7, 2024
@richardlau @targos
Revert "build: workaround for node-core-utils"
fd86ea8 
This reverts commit b2a6083.

PR-URL: #51975
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@targos targos mentioned this pull request Mar 7, 2024
Merged
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
Revert "build: workaround for node-core-utils"
2715ec4 
This reverts commit b2a6083.

PR-URL: #51975
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
Revert "build: workaround for node-core-utils"
9f5547a 
This reverts commit b2a6083.

PR-URL: #51975
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@richardlau @rdw-msft
Revert "build: workaround for node-core-utils"
2d1ebcd 
This reverts commit b2a6083.

PR-URL: nodejs#51975
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardlau @nodejs-github-bot @Trott @anonrig