Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: automate gyp-next update #52014

Merged

Conversation

marco-ippolito
Copy link
Member

automates gyp-next update: #52011

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 8, 2024
tools/dep_updaters/update-gyp-next.sh Outdated Show resolved Hide resolved
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 10, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 11, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/52014
✔  Done loading data for nodejs/node/pull/52014
----------------------------------- PR info ------------------------------------
Title      tools: automate gyp-next update (#52014)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/automate-gyp-next-update -> nodejs:main
Labels     meta, tools, author ready
Commits    2
 - tools: automate gyp-next update
 - Update tools/dep_updaters/update-gyp-next.sh
Committers 2
 - marco-ippolito 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/52014
Reviewed-By: Chengzhong Wu 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52014
Reviewed-By: Chengzhong Wu 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 08 Mar 2024 14:58:56 GMT
   ✔  Approvals: 2
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/52014#pullrequestreview-1925400170
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52014#pullrequestreview-1925680180
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52014
From https://github.com/nodejs/node
 * branch                  refs/pull/52014/merge -> FETCH_HEAD
✔  Fetched commits as 328642bbb98d..23d99af30099
--------------------------------------------------------------------------------
[main f2ddbe797f] tools: automate gyp-next update
 Author: marco-ippolito 
 Date: Fri Mar 8 15:57:59 2024 +0100
 2 files changed, 75 insertions(+)
 create mode 100755 tools/dep_updaters/update-gyp-next.sh
[main c5c0fe38f0] Update tools/dep_updaters/update-gyp-next.sh
 Author: Marco Ippolito 
 Date: Fri Mar 8 18:56:13 2024 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: automate gyp-next update

PR-URL: #52014
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 66e5b2066e] tools: automate gyp-next update
Author: marco-ippolito marcoippolito54@gmail.com
Date: Fri Mar 8 15:57:59 2024 +0100
2 files changed, 75 insertions(+)
create mode 100755 tools/dep_updaters/update-gyp-next.sh
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update tools/dep_updaters/update-gyp-next.sh

Co-authored-by: Chengzhong Wu legendecas@gmail.com
PR-URL: #52014
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 6d2ea89f2c] Update tools/dep_updaters/update-gyp-next.sh
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Fri Mar 8 18:56:13 2024 +0100
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/8231189376

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit cde37e7 into nodejs:main Mar 11, 2024
34 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cde37e7

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
PR-URL: nodejs#52014
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito added a commit that referenced this pull request May 2, 2024
PR-URL: #52014
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito added a commit that referenced this pull request May 3, 2024
PR-URL: #52014
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
PR-URL: nodejs#52014
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
PR-URL: nodejs#52014
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants