src: return a number from process.constrainedMemory() constantly #52039
+9
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
`0` is already a special value returned from `uv_get_constrained_memory` representing unknown or no constraint. Make `process.constrainedMemory()` constantly return a number instead to avoid polymorphic return type.
legendecas
force-pushed
the
process/contrained
branch
from
5abd452 to
8636d85
Compare
theanarkh
approved these changes
Mar 11, 2024
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Mar 11, 2024
anonrig
approved these changes
Mar 12, 2024
H4ad
approved these changes
Mar 12, 2024
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/52039 ✔ Done loading data for nodejs/node/pull/52039 ----------------------------------- PR info ------------------------------------ Title src: return a number from process.constrainedMemory() constantly (#52039) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:process/contrained -> nodejs:main Labels c++, author ready, needs-ci Commits 1 - src: return a number from process.constrainedMemory() constantly Committers 1 - Chengzhong Wu PR-URL: https://github.com/nodejs/node/pull/52039 Reviewed-By: theanarkh Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52039 Reviewed-By: theanarkh Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 11 Mar 2024 03:12:45 GMT ✔ Approvals: 4 ✔ - theanarkh (@theanarkh): https://github.com/nodejs/node/pull/52039#pullrequestreview-1927842122 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52039#pullrequestreview-1928906443 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52039#pullrequestreview-1929946866 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52039#pullrequestreview-1929954111 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-03-13T09:59:10Z: https://ci.nodejs.org/job/node-test-pull-request/57724/ - Querying data for job/node-test-pull-request/57724/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8274632124 Unexpected report on GitHub CI failure. |
nodejs-github-bot
added
the
commit-queue-failed
legendecas
added a commit
that referenced
this pull request
Mar 14, 2024
`0` is already a special value returned from `uv_get_constrained_memory` representing unknown or no constraint. Make `process.constrainedMemory()` constantly return a number instead to avoid polymorphic return type. PR-URL: #52039 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
|
Landed in 0eb2b72 |
legendecas
removed
the
commit-queue-failed
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
`0` is already a special value returned from `uv_get_constrained_memory` representing unknown or no constraint. Make `process.constrainedMemory()` constantly return a number instead to avoid polymorphic return type. PR-URL: nodejs#52039 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
`0` is already a special value returned from `uv_get_constrained_memory` representing unknown or no constraint. Make `process.constrainedMemory()` constantly return a number instead to avoid polymorphic return type. PR-URL: #52039 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
`0` is already a special value returned from `uv_get_constrained_memory` representing unknown or no constraint. Make `process.constrainedMemory()` constantly return a number instead to avoid polymorphic return type. PR-URL: #52039 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
jcbhmr
pushed a commit
to jcbhmr/node
that referenced
this pull request
May 15, 2024
`0` is already a special value returned from `uv_get_constrained_memory` representing unknown or no constraint. Make `process.constrainedMemory()` constantly return a number instead to avoid polymorphic return type. PR-URL: nodejs#52039 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0is already a special value returned fromuv_get_constrained_memoryrepresenting unknown or no constraint.Make
process.constrainedMemory()constantly return a number insteadto avoid polymorphic return type.
Also,
test/parallel/test-process-constrained-memory.jsis evaluated withtools/run-worker.js, it is not necessary to run the test in a worker context manually.