Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix move after use reported by coverity #52141

Closed
wants to merge 1 commit into from
Closed

src: fix move after use reported by coverity #52141

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

  • Fix move after use reported by coverity in node_contextify.cc

@mhdawson
src: fix move after use reported by coverity
9f87c19 
- Fix move after use reported by coverity in
  node_contextify.cc

Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Mar 18, 2024
@mhdawson
Copy link
Member Author

Report from coverity

        code = String::Concat(
1524              isolate,
1525              code,
1526              String::NewFromUtf8(isolate, "})();").ToLocalChecked());
1527          ScriptCompiler::Source wrapped_source = GetCommonJSSourceInstance(
1528              isolate, code, filename, 0, 0, host_defined_options, nullptr);
      	
CID 352925: (#1 of 1): Using a moved object (USE_AFTER_MOVE)
18. use_after_move: params is used after it has been already moved.
1529          std::ignore = ScriptCompiler::CompileFunction(
1530              context,
1531              &wrapped_source,

Looks like recent PR added use of params later on

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57837/

mhdawson added a commit that referenced this pull request Mar 22, 2024
@mhdawson
src: fix move after use reported by coverity
0431922 
- Fix move after use reported by coverity in
  node_contextify.cc

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52141
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson
Copy link
Member Author

Landed in 0431922

@mhdawson mhdawson closed this Mar 22, 2024
anonrig pushed a commit to anonrig/node that referenced this pull request Mar 25, 2024
@mhdawson @anonrig
src: fix move after use reported by coverity
8fa1670 
- Fix move after use reported by coverity in
  node_contextify.cc

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52141
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@mhdawson @rdw-msft
src: fix move after use reported by coverity
c6b1be0 
- Fix move after use reported by coverity in
  node_contextify.cc

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52141
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@legendecas legendecas legendecas approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mhdawson @nodejs-github-bot @GeoffreyBooth @lpinca @anonrig @legendecas