Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: sync ubsan workflow with asan #52152

Merged
merged 6 commits into from Mar 21, 2024
Merged

tools: sync ubsan workflow with asan #52152

merged 6 commits into from Mar 21, 2024

Conversation

targos
Copy link
Member

@targos targos commented Mar 19, 2024

Configs have changed since the ubsan PR was initially opened.

@targos
tools: sync ubsan workflow with asan
7b51843 
Configs have changed since the ubsan PR was initially opened.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 19, 2024
@targos
Copy link
Member Author

targos commented Mar 19, 2024

Had to push a fix so the workflow runs when it's updated.

@targos
Update test-ubsan.yml
2dfc88c 
fixup: try to build with -j3
@targos
Copy link
Member Author

targos commented Mar 19, 2024

ubsan build is very long!

@targos
Copy link
Member Author

targos commented Mar 19, 2024

just realized that the second failure was at the test step. Back to -j3, now in both steps.

@targos
Copy link
Member Author

targos commented Mar 19, 2024

finally green

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 20, 2024
@targos targos mentioned this pull request Mar 21, 2024
Closed
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit f05b241 into nodejs:main Mar 21, 2024
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f05b241

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@targos @rdw-msft
tools: sync ubsan workflow with asan
06cad14 
Configs have changed since the ubsan PR was initially opened.

PR-URL: nodejs#52152
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos deleted the update-ubsan branch April 5, 2024 09:53
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@targos @nodejs-github-bot @benjamingr @lpinca @anonrig @gengjiawen @richardlau @marco-ippolito @aduh95