test: do not set concurrency on parallelized runs #52177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our CI already run test files in parallel, having `node:test` spawns child processes concurrently could lead to oversubscribing the CI machine. This commit sets the `concurrency` depending on the presence of `TEST_PARALLEL` in the env, so running the test file individually still spawns child processes concurrently, and running the whole test suite does not oversubscribe the machine.
nodejs-github-bot
added
esm
H4ad
approved these changes
Mar 22, 2024
H4ad
reviewed
Mar 22, 2024
| describe('--experimental-detect-module', { concurrency: true }, () => { | ||
| describe('string input', { concurrency: true }, () => { | ||
| describe('--experimental-detect-module', { concurrency: !process.env.TEST_PARALLEL }, () => { | ||
| describe('string input', { concurrency: !process.env.TEST_PARALLEL }, () => { |
There was a problem hiding this comment.
Since concurrency is inherited from the parent, do we need to enable it twice here?
There was a problem hiding this comment.
I'll be honest, I only did a quick search and replace, I didn't look closely at the code. I'm tempted to not bother, even if it's redundant, it doesn't harm.
lpinca
approved these changes
Mar 22, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
Mar 23, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in bae14b7 |
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Mar 25, 2024
Our CI already run test files in parallel, having `node:test` spawns child processes concurrently could lead to oversubscribing the CI machine. This commit sets the `concurrency` depending on the presence of `TEST_PARALLEL` in the env, so running the test file individually still spawns child processes concurrently, and running the whole test suite does not oversubscribe the machine. PR-URL: nodejs#52177 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Our CI already run test files in parallel, having `node:test` spawns child processes concurrently could lead to oversubscribing the CI machine. This commit sets the `concurrency` depending on the presence of `TEST_PARALLEL` in the env, so running the test file individually still spawns child processes concurrently, and running the whole test suite does not oversubscribe the machine. PR-URL: nodejs#52177 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI already run test files in parallel, having
node:testspawns child processes concurrently could lead to oversubscribing the CI machine. This commit sets theconcurrencydepending on the presence ofTEST_PARALLELin the env, so running the test file individually still spawns child processes concurrently, and running the whole test suite does not oversubscribe the machine.