Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: backports for gcc 12 #52183

Closed
wants to merge 2 commits into from
Closed

Commits on Mar 21, 2024

  1. deps: V8: cherry-pick f8d5e576b814

    Original commit message:
    
        Fix build with older versions of GCC.
    
        This ports the change from bazel on v8:
        https://crrev.com/c/3368869
    
        Compilation errors started showing after this CL:
        https://crrev.com/c/5199515
    
        Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
        Cr-Commit-Position: refs/heads/main@{#92252}
    
    Refs: v8/v8@f8d5e57
    richardlau committed Mar 21, 2024
    Copy the full SHA
    9390aa3 View commit details
    Browse the repository at this point in the history
  2. deps: V8: backport c4be0a97f981

    Original commit message:
    
        Fix build with gcc12
    
        - A number of erroneous flags have been added to BUILD.gn
        - wasm-init-expr.cc is creating an 8 byte buffer witch may be
          much smaller than max size_t output. We also need to make room
          for the `f` character and the terminating null character
        - inspector_protocol currently generates the following error
           ```
           error: loop variable ‘json_in’ of type ‘const std::string&’ {aka
           ‘const std::__cxx11::basic_string<char>&’} binds to a temporary
           constructed from type ‘const char* const’
           ```
    
        Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756
        Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
        Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#92615}
    
    Refs: v8/v8@c4be0a9
    richardlau committed Mar 21, 2024
    Copy the full SHA
    d1cb8c1 View commit details
    Browse the repository at this point in the history