string_decoder: throw an error when writing a too long buffer

[kylo5aby]

Fixes: #52214

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/57966/

[theanarkh]

The test will fail on some platforms. It looks like 2**31 is too big.

13:29:07 not ok 947 pummel/test-string-decoder-large-buffer
13:29:07   ---
13:29:07   duration_ms: 231.98500
13:29:07   severity: fail
13:29:07   exitcode: 1
13:29:07   stack: |-
13:29:07     C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:24
13:29:07         throw e;
13:29:07         ^
13:29:07     
13:29:07     RangeError [ERR_OUT_OF_RANGE]: The value of "size" is out of range. It must be >= 0 && <= 2147483647. Received 2147483648
13:29:07         at Function.alloc (node:buffer:389:3)
13:29:07         at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:18:22)
13:29:07         at Module._compile (node:internal/modules/cjs/loader:1421:14)
13:29:07         at Module._extensions..js (node:internal/modules/cjs/loader:1499:10)
13:29:07         at Module.load (node:internal/modules/cjs/loader:1232:32)
13:29:07         at Module._load (node:internal/modules/cjs/loader:1048:12)
13:29:07         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:187:14)
13:29:07         at node:internal/main/run_main_module:28:49 {
13:29:07       code: 'ERR_OUT_OF_RANGE'
13:29:07     }
13:29:07     

[kylo5aby]

The test will fail on some platforms. It looks like 2**31 is too big.

13:29:07 not ok 947 pummel/test-string-decoder-large-buffer
13:29:07   ---
13:29:07   duration_ms: 231.98500
13:29:07   severity: fail
13:29:07   exitcode: 1
13:29:07   stack: |-
13:29:07     C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:24
13:29:07         throw e;
13:29:07         ^
13:29:07     
13:29:07     RangeError [ERR_OUT_OF_RANGE]: The value of "size" is out of range. It must be >= 0 && <= 2147483647. Received 2147483648
13:29:07         at Function.alloc (node:buffer:389:3)
13:29:07         at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:18:22)
13:29:07         at Module._compile (node:internal/modules/cjs/loader:1421:14)
13:29:07         at Module._extensions..js (node:internal/modules/cjs/loader:1499:10)
13:29:07         at Module.load (node:internal/modules/cjs/loader:1232:32)
13:29:07         at Module._load (node:internal/modules/cjs/loader:1048:12)
13:29:07         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:187:14)
13:29:07         at node:internal/main/run_main_module:28:49 {
13:29:07       code: 'ERR_OUT_OF_RANGE'
13:29:07     }
13:29:07     

I believe it's because of the buffer with size > INT32_MAX on x32 platform which will throw range error, I have updated and skip the test file on x32 platform

[kylo5aby]

@theanarkh Could you pls retrigger CI?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58651/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58673/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58689/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58749/