Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL #52217

Merged
merged 3 commits into from Apr 11, 2024
Merged

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL #52217

merged 3 commits into from Apr 11, 2024

Conversation

codebytere
Copy link
Member

As in title. It's possible for NODE_EXTRA_CA_CERTS to work in a BoringSSL context, so there's no need to include that in the guard. This allows Electron users to leverage it.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 26, 2024
@codebytere codebytere mentioned this pull request Mar 26, 2024
Merged
5 tasks
tniessen
tniessen reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This increases the number of #endif directives without changing the number of #if directives. You'll need to split the existing #if ... && ... into two separate directives in order to use separate #endif directives for the two conditions.

@codebytere
Copy link
Member Author

@tniessen oops, forgot to push that 😅 fixed.

tniessen
tniessen reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, the commit message does not adhere to the guidelines, I'd suggest crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL or something along those lines.

src/node.cc Outdated Show resolved Hide resolved
@tniessen tniessen changed the title crypto: BoringSSL can work with NODE_EXTRA_CA_CERTS crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL Mar 26, 2024
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57959/

anonrig
anonrig approved these changes Mar 26, 2024
View reviewed changes
src/node.cc Outdated Show resolved Hide resolved
@codebytere @anonrig
Update src/node.cc
eaa7289 
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
lpinca
lpinca approved these changes Mar 26, 2024
View reviewed changes
src/node.cc Outdated Show resolved Hide resolved
@codebytere @lpinca
Update src/node.cc
82b82e8 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58264/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58277/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58284/

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit 28d68f3 into nodejs:main Apr 11, 2024
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 28d68f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@codebytere @nodejs-github-bot @addaleax @lpinca @anonrig @tniessen @richardlau