test,crypto: update WebCryptoAPI WPT #52222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
|
Review requested:
|
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Mar 26, 2024
This comment was marked as outdated.
This comment was marked as outdated.
These vectors pass on rhel... I'll need to figure out how to conditionally change the expectations. |
|
@mhdawson is there a way to detect rhel in the Node.js process so that these expectations can be made dynamic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just
git node wpt WebCryptoAPIand acknowledging failures.cc @tniessen @nodejs/crypto see web-platform-tests/wpt#43751 if there's anything we can do about these failures. Other implementations also fail these.