streams: fix util inspect returning undefined for CompressionStream & DecompressionStream #52283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/nodejs/node/blob/021cf912084005f4ecd7db06e0bad75353067a46/test/parallel/test-whatwg-webstreams-compression.js#L1C2-L74C6 |
lpinca
approved these changes
Mar 30, 2024
mertcanaltin
force-pushed
the
dev-52263
branch
2 times, most recently
from
fce8ced
to
1d59e3d
Compare
daeyeon
approved these changes
Apr 1, 2024
atlowChemi
approved these changes
Apr 2, 2024
KhafraDev
approved these changes
Apr 2, 2024
mertcanaltin
force-pushed
the
dev-52263
branch
5 times, most recently
from
f01357c
to
4c5570f
Compare
panva
approved these changes
Apr 5, 2024
github-actions
bot
removed
the
request-ci
atlowChemi
added
the
author ready
panva
added
request-ci
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Apr 11, 2024
deokjinkim
approved these changes
Apr 28, 2024
MoLow
approved these changes
Apr 28, 2024
|
this PR seems to be missing a test. @mertcanaltin can you please add on in a follow-up pr? |
MoLow
approved these changes
Apr 28, 2024
I wonder if this is true, I interpreted it as no need for a test @MoLow |
|
@mertcanaltin adding a test is always good to prevent regressions. So far this is clearly not covered, otherwise it would have been detected :) |
|
Thank you very much for the details, I will add it immediately |
aduh95
approved these changes
May 10, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
May 11, 2024
github-actions
bot
removed
the
request-ci
|
Landed in cd155d6 |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
PR-URL: #52283 Fixes: #52263 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The customInspect method within the internal module node/lib/internal/webstreams/compression.js was missing a return statement, causing util.inspect to return undefined when inspecting instances of CompressionStream and DecompressionStream. This commit adds the missing return statement to ensure that util.inspect displays the correct information for these stream instances.
Fixes: #52263