Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "tools: run build-windows workflow only on source changes" #52320

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Revert "tools: run build-windows workflow only on source changes" #52320

merged 1 commit into from
Apr 4, 2024

Conversation

targos
Copy link
Member

@targos targos commented Apr 2, 2024

This reverts commit 4ab63db.

Refs: #51596

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 2, 2024
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit d7aa8fc into nodejs:main Apr 4, 2024
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d7aa8fc

@targos targos deleted the revert-build-windows branch April 4, 2024 12:45
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@targos @marco-ippolito
Revert "tools: run build-windows workflow only on source changes"
f06acc8 
This reverts commit 4ab63db.

PR-URL: #52320
Refs: #51596
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@targos @marco-ippolito
Revert "tools: run build-windows workflow only on source changes"
049cca4 
This reverts commit 4ab63db.

PR-URL: #52320
Refs: #51596
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@targos @lukins-cz
Revert "tools: run build-windows workflow only on source changes"
c857000 
This reverts commit 4ab63db.

PR-URL: nodejs#52320
Refs: nodejs#51596
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@targos @nodejs-github-bot @lpinca @UlisesGascon @richardlau @StefanStojanovic @marco-ippolito