Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix clearing final timeout inside own callback #52332

Closed
wants to merge 1 commit into from
Closed

test_runner: fix clearing final timeout inside own callback #52332

wants to merge 1 commit into from
+14 −1

Conversation

Benricheson101
Copy link
Contributor

Fixes: #52325

Clearing the final mocked timeout left in the execution queue inside its own callback causes an error to be thrown when trying to access its id because it is not treated as nullable.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner labels Apr 2, 2024
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58131/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58259/

MoLow pushed a commit that referenced this pull request Apr 11, 2024
@Benricheson101 @MoLow
test_runner: fix clearing final timeout in own callback
3f8cc88 
PR-URL: #52332
Fixes: #52325
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow
Copy link
Member

MoLow commented Apr 11, 2024

Landed in 3f8cc88

@MoLow MoLow closed this Apr 11, 2024
@MoLow
Copy link
Member

MoLow commented Apr 11, 2024

landed manually, CI completed but GitHub bot seems to not work (probably reached some limit du to ci unlocked after security release)

@richardlau richardlau added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Apr 11, 2024
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@Benricheson101 @marco-ippolito
test_runner: fix clearing final timeout in own callback
048bf79 
PR-URL: #52332
Fixes: #52325
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@Benricheson101 @marco-ippolito
test_runner: fix clearing final timeout in own callback
9497097 
PR-URL: #52332
Fixes: #52325
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@Benricheson101 @lukins-cz
test_runner: fix clearing final timeout in own callback
e23823f 
PR-URL: nodejs#52332
Fixes: nodejs#52325
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x needs-ci PRs that need a full CI run. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mock timers broken with 20.12.0 / 21.7.0
8 participants
@Benricheson101 @nodejs-github-bot @MoLow @benjamingr @cjihrig @atlowChemi @richardlau @debadree25