lib: improve perf of `AbortSignal` creation #52408

rluvaton · 2024-04-07T19:32:29Z

Benchmarks

even thought the following issue nodejs/build#3657 (comment), I ran 3 times to make sure it's consistent and it is

`AbortSignal.abort()` creation

                                                                              confidence improvement accuracy (*)    (**)   (***)
abort_controller/abort-signal-static-abort.js kind='default-reason' n=5000000        ***     76.76 %       ±0.46%  ±0.62%  ±0.80%
abort_controller/abort-signal-static-abort.js kind='same-reason' n=5000000           ***   2166.62 %      ±11.82% ±15.93% ±21.15%

Benchmark URL 2

                                                                              confidence improvement accuracy (*)    (**)   (***)
abort_controller/abort-signal-static-abort.js kind='default-reason' n=5000000        ***     75.92 %       ±0.68%  ±0.90%  ±1.18%
abort_controller/abort-signal-static-abort.js kind='same-reason' n=5000000           ***   2191.80 %      ±10.63% ±14.32% ±19.01%

Benchmark URL 3

                                                                              confidence improvement accuracy (*)    (**)   (***)
abort_controller/abort-signal-static-abort.js kind='default-reason' n=5000000        ***     75.79 %       ±0.45%  ±0.60%  ±0.79%
abort_controller/abort-signal-static-abort.js kind='same-reason' n=5000000           ***   2192.39 %      ±26.46% ±35.66% ±47.34%

Test runner Benchmark

My original intent was to improve this so this is why I ran this

Benchmark URL

                                                                                                     confidence improvement accuracy (*)   (**)   (***)
test_runner/global-concurrent-tests.js type='async' n=100                                                           3.46 %       ±4.37% ±5.81%  ±7.57%
test_runner/global-concurrent-tests.js type='async' n=1000                                                 ***      5.92 %       ±2.26% ±3.03%  ±3.97%
test_runner/global-concurrent-tests.js type='async' n=10000                                                ***     15.70 %       ±0.55% ±0.73%  ±0.96%
test_runner/global-concurrent-tests.js type='sync' n=100                                                    **      3.89 %       ±2.47% ±3.29%  ±4.29%
test_runner/global-concurrent-tests.js type='sync' n=1000                                                  ***      5.00 %       ±1.82% ±2.44%  ±3.21%
test_runner/global-concurrent-tests.js type='sync' n=10000                                                 ***     15.41 %       ±0.39% ±0.52%  ±0.68%
test_runner/global-sequential-tests.js type='async' n=100                                                           6.22 %       ±7.36% ±9.81% ±12.78%
test_runner/global-sequential-tests.js type='async' n=1000                                                          2.51 %       ±5.83% ±7.77% ±10.12%
test_runner/global-sequential-tests.js type='async' n=10000                                                         0.00 %       ±2.77% ±3.68%  ±4.79%
test_runner/global-sequential-tests.js type='sync' n=100                                                            1.06 %       ±4.42% ±5.90%  ±7.70%
test_runner/global-sequential-tests.js type='sync' n=1000                                                           0.13 %       ±3.39% ±4.51%  ±5.88%
test_runner/global-sequential-tests.js type='sync' n=10000                                                         -3.01 %       ±3.11% ±4.14%  ±5.39%
test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=10 numberOfSuites=10            ***      5.77 %       ±2.99% ±4.01%  ±5.27%
test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=10 numberOfSuites=100           ***     12.06 %       ±0.71% ±0.94%  ±1.23%
test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=100 numberOfSuites=10           ***      9.29 %       ±1.05% ±1.40%  ±1.83%
test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=100 numberOfSuites=100          ***     15.06 %       ±0.38% ±0.50%  ±0.65%
test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=1000 numberOfSuites=10          ***     16.90 %       ±1.59% ±2.15%  ±2.84%
test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=1000 numberOfSuites=100         ***     17.62 %       ±1.01% ±1.35%  ±1.79%
test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=10 numberOfSuites=10                      3.59 %       ±4.91% ±6.54%  ±8.51%
test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=10 numberOfSuites=100            ***     11.88 %       ±0.78% ±1.04%  ±1.36%
test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=100 numberOfSuites=10            ***     10.44 %       ±1.64% ±2.20%  ±2.89%
test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=100 numberOfSuites=100           ***     15.72 %       ±0.51% ±0.68%  ±0.88%
test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=1000 numberOfSuites=10           ***     18.30 %       ±1.72% ±2.32%  ±3.07%
test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=1000 numberOfSuites=100          ***     17.40 %       ±1.26% ±1.70%  ±2.25%
test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=10 numberOfSuites=10             *      4.00 %       ±3.31% ±4.41%  ±5.74%
test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=10 numberOfSuites=100          ***     10.96 %       ±0.66% ±0.87%  ±1.14%
test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=100 numberOfSuites=10          ***      9.11 %       ±0.79% ±1.05%  ±1.37%
test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=100 numberOfSuites=100         ***     16.58 %       ±0.42% ±0.56%  ±0.73%
test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=1000 numberOfSuites=10         ***     16.72 %       ±0.40% ±0.53%  ±0.70%
test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=1000 numberOfSuites=100        ***     15.42 %       ±0.19% ±0.26%  ±0.33%
test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=10 numberOfSuites=10            ***      6.09 %       ±1.99% ±2.65%  ±3.47%
test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=10 numberOfSuites=100           ***      9.95 %       ±1.28% ±1.71%  ±2.22%
test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=100 numberOfSuites=10           ***      9.46 %       ±1.58% ±2.10%  ±2.73%
test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=100 numberOfSuites=100          ***     16.19 %       ±0.47% ±0.63%  ±0.81%
test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=1000 numberOfSuites=10          ***     17.06 %       ±0.25% ±0.33%  ±0.43%
test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=1000 numberOfSuites=100         ***     15.00 %       ±0.17% ±0.23%  ±0.30%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 36 comparisons, you can thus
expect the following amount of false-positive results:
1.80 false positives, when considering a   5% risk acceptance (*, **, ***),
0.36 false positives, when considering a   1% risk acceptance (**, ***),
0.04 false positives, when considering a 0.1% risk acceptance (***)

nodejs-github-bot · 2024-04-07T20:25:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58182/

nodejs-github-bot · 2024-04-07T23:09:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58192/

github-actions · 2024-04-08T00:07:30Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

anonrig · 2024-04-08T00:07:40Z

I added notable change label because it improves test runner performance significantly. Nice job!

H4ad · 2024-04-08T01:11:02Z

If I'm not wrong, this could also help fetch, @mcollina I'm right?

lib/internal/abort_controller.js

KhafraDev · 2024-04-08T04:50:58Z

If I'm not wrong, this could also help fetch

no, it won't

mcollina

lgtm

targos

Commit message must be fixed

rluvaton · 2024-04-08T11:19:53Z

Commit message must be fixed

@targos what do you mean? the commit message is valid

targos · 2024-04-08T11:28:50Z

AbortListener doesn't exist

rluvaton · 2024-04-08T11:43:05Z

🤦🏻 , thanks, fixed

H4ad · 2024-04-10T01:09:47Z

According to nodejs/undici#1203 (comment), this improvement probably will help fetch.

By how much I don't know, but I think is worth re-running the benchmarks.

EDIT:

I build this PR and tried to check the benchmarks and here's the results (I didn't run in a isolated machine, results are not 100% reliable):

Before:

│ Tests               │ Samples │          Result │ Tolerance │ Difference with slowest │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - fetch      │       1 │ 1453.82 req/sec │  ± 0.00 % │                       - │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ http - no keepalive │       1 │ 1803.32 req/sec │  ± 0.00 % │               + 24.04 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ http - keepalive    │       1 │ 2468.37 req/sec │  ± 0.00 % │               + 69.78 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - pipeline   │       1 │ 2882.04 req/sec │  ± 0.00 % │               + 98.24 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - request    │       1 │ 3665.71 req/sec │  ± 0.00 % │              + 152.14 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - stream     │       1 │ 4956.87 req/sec │  ± 0.00 % │              + 240.96 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - dispatch   │       1 │ 5217.81 req/sec │  ± 0.00 % │              + 258.90 % │

After:

│ Tests               │ Samples │          Result │ Tolerance │ Difference with slowest │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - fetch      │       1 │ 1548.19 req/sec │  ± 0.00 % │                       - │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ http - no keepalive │       1 │ 2024.41 req/sec │  ± 0.00 % │               + 30.76 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ http - keepalive    │       1 │ 2485.63 req/sec │  ± 0.00 % │               + 60.55 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - pipeline   │       1 │ 2868.73 req/sec │  ± 0.00 % │               + 85.30 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - stream     │       1 │ 4770.42 req/sec │  ± 0.00 % │              + 208.13 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - request    │       1 │ 4965.85 req/sec │  ± 0.00 % │              + 220.75 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - dispatch   │       1 │ 7059.16 req/sec │  ± 0.00 % │              + 355.96 % │

Looks like it helped more the dispatch than the fetch itself.

nodejs-github-bot · 2024-04-10T19:55:24Z

Commit Queue failed

- Loading data for nodejs/node/pull/52408 ✔ Done loading data for nodejs/node/pull/52408 ----------------------------------- PR info ------------------------------------ Title lib: improve perf of `AbortSignal` creation (#52408) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rluvaton:improve-abort-listener-creation -> nodejs:main Labels performance, notable-change, author ready, needs-ci, needs-benchmark-ci, abortcontroller Commits 2 - lib: improve perf of `AbortSignal` creation - benchmark: add AbortSignal.abort benchmarks Committers 1 - Raz Luvaton <16746759+rluvaton@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/52408 Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Matteo Collina Reviewed-By: Michaël Zasso Reviewed-By: Moshe Atlow Reviewed-By: Minwoo Jung Reviewed-By: Matthew Aitken ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52408 Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Matteo Collina Reviewed-By: Michaël Zasso Reviewed-By: Moshe Atlow Reviewed-By: Minwoo Jung Reviewed-By: Matthew Aitken -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 07 Apr 2024 19:32:29 GMT ✔ Approvals: 7 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52408#pullrequestreview-1990239890 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52408#pullrequestreview-1986280591 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52408#pullrequestreview-1986078515 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/52408#pullrequestreview-1986200098 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52408#pullrequestreview-1986182193 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/52408#pullrequestreview-1988304222 ✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/52408#pullrequestreview-1990496635 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-08T13:26:47Z: https://ci.nodejs.org/job/node-test-pull-request/58211/ - Querying data for job/node-test-pull-request/58211/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52408 From https://github.com/nodejs/node * branch refs/pull/52408/merge -> FETCH_HEAD ✔ Fetched commits as 423ad47e0f59..4eaacb47a489 -------------------------------------------------------------------------------- [main bce2c15364] lib: improve perf of `AbortSignal` creation Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sun Apr 7 22:32:02 2024 +0300 1 file changed, 38 insertions(+), 37 deletions(-) [main 96f0e67dd7] benchmark: add AbortSignal.abort benchmarks Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sun Apr 7 22:49:56 2024 +0300 1 file changed, 29 insertions(+) create mode 100644 benchmark/abort_controller/abort-signal-static-abort.js ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
lib: improve perf of AbortSignal creation

PR-URL: #52408
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
Reviewed-By: Matthew Aitken maitken033380023@gmail.com

[detached HEAD d2cec92ac9] lib: improve perf of AbortSignal creation
Author: Raz Luvaton 16746759+rluvaton@users.noreply.github.com
Date: Sun Apr 7 22:32:02 2024 +0300
1 file changed, 38 insertions(+), 37 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
benchmark: add AbortSignal.abort benchmarks

PR-URL: #52408
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
Reviewed-By: Matthew Aitken maitken033380023@gmail.com

[detached HEAD 707b34a11d] benchmark: add AbortSignal.abort benchmarks
Author: Raz Luvaton 16746759+rluvaton@users.noreply.github.com
Date: Sun Apr 7 22:49:56 2024 +0300
1 file changed, 29 insertions(+)
create mode 100644 benchmark/abort_controller/abort-signal-static-abort.js

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/8637006962

nodejs-github-bot · 2024-04-10T20:16:06Z

Landed in 64b6777...a760dad

PR-URL: #52408 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

marco-ippolito · 2024-04-17T17:30:27Z

@rluvaton can you add the description for the notable change?

rluvaton · 2024-04-17T20:00:51Z

With the help of @anonrig

Creating AbortSignal’s have been significantly faster. This change results in improving fetch performance as well as the test runner performance.

PR-URL: #52408 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: TODO

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

PR-URL: #52408 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492 doc: * update release gpg keyserver (marco-ippolito) nodejs#52257 * add release key for marco-ippolito (marco-ippolito) nodejs#52257 * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618 fs: * add stacktrace to fs/promises (翠 / green) nodejs#49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927 watch: * mark as stable (Moshe Atlow) nodejs#52074 PR-URL: nodejs#52793

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 7, 2024

rluvaton force-pushed the improve-abort-listener-creation branch from 9b06e6c to 65dd60f Compare April 7, 2024 19:34

rluvaton marked this pull request as ready for review April 7, 2024 19:38

rluvaton added performance Issues and PRs related to the performance of Node.js. needs-benchmark-ci PR that need a benchmark CI run. abortcontroller Issues and PRs related to the AbortController API labels Apr 7, 2024

rluvaton force-pushed the improve-abort-listener-creation branch from 437416d to 1952037 Compare April 7, 2024 19:54

rluvaton mentioned this pull request Apr 7, 2024

ignore me #52411

Closed

rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2024

anonrig approved these changes Apr 7, 2024

View reviewed changes

H4ad approved these changes Apr 7, 2024

View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. notable-change PRs with changes that should be highlighted in changelogs. labels Apr 8, 2024

climba03003 reviewed Apr 8, 2024

View reviewed changes

lib/internal/abort_controller.js Show resolved Hide resolved

mcollina approved these changes Apr 8, 2024

View reviewed changes

targos requested changes Apr 8, 2024

View reviewed changes

rluvaton added 2 commits April 8, 2024 14:42

lib: improve perf of AbortSignal creation

445b30d

benchmark: add AbortSignal.abort benchmarks

4eaacb4

rluvaton force-pushed the improve-abort-listener-creation branch from 1952037 to 4eaacb4 Compare April 8, 2024 11:42

rluvaton changed the title ~~lib: improve perf of AbortListener creation~~ lib: improve perf of AbortSignal creation Apr 8, 2024

anonrig approved these changes Apr 9, 2024

View reviewed changes

KhafraDev approved these changes Apr 10, 2024

View reviewed changes

rluvaton added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 10, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2024

nodejs-github-bot closed this Apr 10, 2024

rluvaton deleted the improve-abort-listener-creation branch April 13, 2024 17:24

RafaelGSS mentioned this pull request Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: improve perf of `AbortSignal` creation #52408

lib: improve perf of `AbortSignal` creation #52408

rluvaton commented Apr 7, 2024 •

edited

nodejs-github-bot commented Apr 7, 2024

nodejs-github-bot commented Apr 7, 2024

github-actions bot commented Apr 8, 2024

anonrig commented Apr 8, 2024

H4ad commented Apr 8, 2024

KhafraDev commented Apr 8, 2024

mcollina left a comment

targos left a comment

rluvaton commented Apr 8, 2024

targos commented Apr 8, 2024

rluvaton commented Apr 8, 2024

H4ad commented Apr 10, 2024 •

edited

nodejs-github-bot commented Apr 10, 2024

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Apr 10, 2024

marco-ippolito commented Apr 17, 2024 •

edited

rluvaton commented Apr 17, 2024

lib: improve perf of AbortSignal creation #52408

lib: improve perf of AbortSignal creation #52408

Conversation

rluvaton commented Apr 7, 2024 • edited

Benchmarks

AbortSignal.abort() creation

Test runner Benchmark

nodejs-github-bot commented Apr 7, 2024

nodejs-github-bot commented Apr 7, 2024

github-actions bot commented Apr 8, 2024

anonrig commented Apr 8, 2024

H4ad commented Apr 8, 2024

KhafraDev commented Apr 8, 2024

mcollina left a comment

Choose a reason for hiding this comment

targos left a comment

Choose a reason for hiding this comment

rluvaton commented Apr 8, 2024

targos commented Apr 8, 2024

rluvaton commented Apr 8, 2024

H4ad commented Apr 10, 2024 • edited

nodejs-github-bot commented Apr 10, 2024

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Apr 10, 2024

marco-ippolito commented Apr 17, 2024 • edited

rluvaton commented Apr 17, 2024

lib: improve perf of `AbortSignal` creation #52408

lib: improve perf of `AbortSignal` creation #52408

rluvaton commented Apr 7, 2024 •

edited

`AbortSignal.abort()` creation

H4ad commented Apr 10, 2024 •

edited

marco-ippolito commented Apr 17, 2024 •

edited