buffer: improve base64 and base64url performance

[anonrig]

The work is mostly done by @lemire.

Suggested changes improves the performance of base64 and base64url operations.

Benchmarks

                                                                                confidence improvement accuracy (*)   (**)  (***)
buffers/buffer-base64-decode-wrapped.js n=32 linesCount=524288 charsPerLine=76        ***    196.05 %       ±2.25% ±3.03% ±4.01%
buffers/buffer-base64-decode.js size=8388608 n=32                                     ***    218.27 %       ±3.45% ±4.65% ±6.16%
buffers/buffer-base64-encode.js n=32 len=67108864                                     ***      2.95 %       ±0.67% ±0.89% ±1.16%
buffers/buffer-base64url-decode.js size=8388608 n=32                                  ***    218.32 %       ±4.34% ±5.84% ±7.74%
buffers/buffer-base64url-encode.js n=32 len=67108864                                  ***    246.27 %       ±2.68% ±3.61% ±4.79%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 5 comparisons, you can thus expect the following amount of false-positive results:
  0.25 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.05 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)

[lemire]

Note that gains are not expected for buffers/buffer-base64-encode.js so the 2.95% result is probably approximately 0%. (I am only pointing out that this is not an issue.)

[Uzlopak]

can we have a btoa too, please?

[anonrig]

@lemire there are some test cases failing. would you mind looking into them?

[lemire]

@Uzlopak @anonrig

can we have a btoa too, please?

This should be "easy".

[lemire]

@anonrig I pushed a commit.

[lemire]

@anonrig I did some additional optimizations.

[mcollina]

lgtm

[lemire]

@anonrig If you get around to it, it would be nice to revisit your benchmarks. I bet that you'd get better numbers with the latest changes.

[anonrig]

@anonrig If you get around to it, it would be nice to revisit your benchmarks. I bet that you'd get better numbers with the latest changes.

The benchmarks didn't show anything, but I'm pretty sure, it has a flaw.

                                                                                confidence improvement accuracy (*)   (**)  (***)
buffers/buffer-base64-decode-wrapped.js n=32 linesCount=524288 charsPerLine=76        ***    191.75 %       ±1.82% ±2.45% ±3.25%
buffers/buffer-base64-decode.js size=8388608 n=32                                     ***    213.25 %       ±2.59% ±3.49% ±4.63%
buffers/buffer-base64-encode.js n=32 len=67108864                                     ***      3.57 %       ±1.21% ±1.61% ±2.10%
buffers/buffer-base64url-decode.js size=8388608 n=32                                  ***    216.97 %       ±0.87% ±1.17% ±1.54%
buffers/buffer-base64url-encode.js n=32 len=67108864                                  ***    244.58 %       ±2.97% ±4.00% ±5.31%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 5 comparisons, you can thus expect the following amount of false-positive results:
  0.25 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.05 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)

[lemire]

The benchmarks didn't show anything, but I'm pretty sure, it has a flaw.

Hmmm...

[github-actions]

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[lemire]

For people who want profiling... here are the numbers for the base64 decoding prior to this PR:

Here are the results after...

So the main bottleneck after this PR is merged will be memmove. Unless we find a way to move less data, this function is unlikely to ever get much faster.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/52428
✔  Done loading data for nodejs/node/pull/52428
----------------------------------- PR info ------------------------------------
Title      buffer: improve `base64` and `base64url` performance (#52428)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:improve-base64-operations -> nodejs:main
Labels     buffer, c++, notable-change, needs-ci, needs-benchmark-ci
Commits    5
 - buffer: improve `base64` and `base64url` performance
 - fix: replace base64_to_binary to account for short inputs
 - lint
 - optimization: fast one-byte case
 - lint
Committers 2
 - Yagiz Nizipli 
 - Daniel Lemire 
PR-URL: https://github.com/nodejs/node/pull/52428
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52428
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 08 Apr 2024 18:07:00 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52428#pullrequestreview-1988350258
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52428#pullrequestreview-1992360558
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/52428#pullrequestreview-1992482467
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-04-12T02:15:07Z: https://ci.nodejs.org/job/node-test-pull-request/58297/
- Querying data for job/node-test-pull-request/58297/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52428
From https://github.com/nodejs/node
 * branch                  refs/pull/52428/merge -> FETCH_HEAD
✔  Fetched commits as abb46cfbc368..c3d6e4d2ac3f
--------------------------------------------------------------------------------
[main 20148b12a9] buffer: improve `base64` and `base64url` performance
 Author: Yagiz Nizipli 
 Date: Mon Apr 8 14:05:25 2024 -0400
 1 file changed, 71 insertions(+), 14 deletions(-)
[main e7668aafc6] fix: replace base64_to_binary to account for short inputs
 Author: Daniel Lemire 
 Date: Mon Apr 8 21:30:36 2024 -0400
 1 file changed, 13 insertions(+), 8 deletions(-)
[main 5c5899a650] lint
 Author: Daniel Lemire 
 Date: Mon Apr 8 21:34:34 2024 -0400
 1 file changed, 6 insertions(+), 6 deletions(-)
[main 05796701f0] optimization: fast one-byte case
 Author: Daniel Lemire 
 Date: Mon Apr 8 23:28:43 2024 -0400
 1 file changed, 35 insertions(+)
[main 89fb1b5f94] lint
 Author: Daniel Lemire 
 Date: Mon Apr 8 23:33:10 2024 -0400
 1 file changed, 12 insertions(+), 4 deletions(-)
   ✔  Patches applied
There are 5 commits in the PR. Attempting autorebase.
Rebasing (2/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

buffer: improve base64 and base64url performance
Co-authored-by: Daniel Lemire daniel@lemire.me

PR-URL: #52428

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com
[detached HEAD 8c4bf57360] buffer: improve base64 and base64url performance

Author: Yagiz Nizipli yagiz@nizipli.com

Date: Mon Apr 8 14:05:25 2024 -0400

1 file changed, 71 insertions(+), 14 deletions(-)

Rebasing (3/10)

Rebasing (4/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix: replace base64_to_binary to account for short inputs
PR-URL: #52428

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com
[detached HEAD b390b7c157] fix: replace base64_to_binary to account for short inputs

Author: Daniel Lemire daniel@lemire.me

Date: Mon Apr 8 21:30:36 2024 -0400

1 file changed, 13 insertions(+), 8 deletions(-)

Rebasing (5/10)

Rebasing (6/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

lint
PR-URL: #52428

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com
[detached HEAD d88f583e23] lint

Author: Daniel Lemire daniel@lemire.me

Date: Mon Apr 8 21:34:34 2024 -0400

1 file changed, 6 insertions(+), 6 deletions(-)

Rebasing (7/10)

Rebasing (8/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

optimization: fast one-byte case
PR-URL: #52428

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com
[detached HEAD 9b1e859800] optimization: fast one-byte case

Author: Daniel Lemire daniel@lemire.me

Date: Mon Apr 8 23:28:43 2024 -0400

1 file changed, 35 insertions(+)

Rebasing (9/10)

Rebasing (10/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

lint
PR-URL: #52428

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com
[detached HEAD 0d0a6e299e] lint

Author: Daniel Lemire daniel@lemire.me

Date: Mon Apr 8 23:33:10 2024 -0400

1 file changed, 12 insertions(+), 4 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/8656195179

[nodejs-github-bot]

Landed in 4221631