build: add missing libnode.lib and copy debug build if built

[segevfiner]

This continues after #52277 and adds the missing libnode.lib and also copies the Debug build if it was built as described in #52281

[mhdawson]

Looks reasonable to me.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58330/

[StefanStojanovic]

From what I see the commit 619768a is present in both this and the previous PR. How do you want to land this? as 2 PRs, or only this one as it includes the commit from the initial one?

[segevfiner]

As you wish. I opened this separately in case you want to merge just the previous change, as the following commit here is a bit more complex and decides things like optionally including a debug build for the experimental shared build in Windows in the resulting packaged dist.

[StefanStojanovic]

And what would be the ideal use case for this in your opinion? Asking because in the original issue you wrote this:

Support building a package from vcbuild.bat for a debug build. Alternatively, we can also just include a Debug directory under the normal release package with the node shared library, import library and def file for debug if debug is built in that tree to produce one package that includes both release and debug builds for the shared node case.

And the way CI is running, Debug and Release are never built together, so effectively, ..\Debug will never exist.

[segevfiner]

shared is also not built in CI AFAIK?

This is for when someone wants to build his own custom shared build for embedding Node.js. It essentially adds the needed files to the built installed tree/package, so you can just use that folder, sharing it, building it locally on each machine, etc.

[StefanStojanovic]

Oh OK, my bad. What I understood was that you'd like this to be added to official releases (I read the quoted message badly). The scenario you mention is completely valid as people building their own custom shared build can do whatever they want eg. build both Release and Debug.

[segevfiner]

The POC where I used this: https://github.com/segevfiner/node-embed

[mhdawson]

Landed in c29d53c

[segevfiner]

So we can close both this and the previous PR? (As it was landed outside of GitHub's merge PR flow).

[mhdawson]

oops should have closed when I landed it.