Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: update ongoing promise in async iterator return() method #52657

Merged
merged 2 commits into from Apr 28, 2024
Merged

stream: update ongoing promise in async iterator return() method #52657

merged 2 commits into from Apr 28, 2024

Conversation

MattiasBuelens
Copy link
Contributor

Fixes #51725

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Apr 23, 2024
@MattiasBuelens MattiasBuelens changed the title streams: update ongoing promise in async iterator return() method stream: update ongoing promise in async iterator return() method Apr 23, 2024
@MattiasBuelens MattiasBuelens force-pushed the streams-async-iterator-return-update-ongoing branch from e3b75f7 to 668a13f Compare April 23, 2024 21:33
mcollina
mcollina approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58747/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58760/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58782/

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Apr 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit eee9db8 into nodejs:main Apr 28, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in eee9db8

@MattiasBuelens MattiasBuelens deleted the streams-async-iterator-return-update-ongoing branch April 28, 2024 19:40
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
@MattiasBuelens @aduh95
stream: update ongoing promise in async iterator return() method
9f9eca9 
PR-URL: #52657
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ongoing promise in async iterator return() method
6 participants
@MattiasBuelens @nodejs-github-bot @mcollina @jasnell @benjamingr @debadree25