child_process: throw different error message for executing batch files w/o shell: true #52685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
RedYetiDev
added
the
child_process
aduh95
reviewed
Apr 25, 2024
RedYetiDev
force-pushed
the
batch-throw-typeerror
branch
from
30cb2cd
to
b64cb6f
Compare
RedYetiDev
removed
the
c++
RedYetiDev
changed the title
RedYetiDev
force-pushed
the
batch-throw-typeerror
branch
from
b64cb6f
to
9063f08
Compare
jasnell
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the error thrown when executing batch files without
shell: truefrom an standardUV_EINVALerror to one with a few more details on how to resolve the issue.