meta: migrate labelling to actions (Discuss / WIP) #52695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
RedYetiDev
commented
Apr 25, 2024
| - name: Initialize Pull Request | ||
| uses: redyetidev/node-actions-runner@v0.0.1 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Could this be GH_USER_TOKEN?
There was a problem hiding this comment.
Forks don't have access to GH_USER_TOKEN, so no (and let's not go the pull_request_target way, it's not worth it because of the bad DX and the security aspects).
richardlau
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Labelling was already going through a GitHub action under the nodejs org: https://github.com/nodejs/node-pr-labeler
Yes, I'm aware. I figured I'd consolidate it into a single workflow while changing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request transitions the webhook and GitHub bot labeling and pinging system to a GitHub action, which I've configured at https://github.com/RedYetiDev/node-actions-runner/tree/main. However, this change has yet to be tested with the Node.js infrastructure, so it's a work in progress.
(This repo could also be moved to an internal one if need be)
Related to #51236
@nodejs/actions
@nodejs/github-bot