watch: allow listening for grouped changes #52722
Merged
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
fix-52721
branch
from
521fa56 to
61eb26c
Compare
|
matthieusieben
force-pushed
the
fix-52721
branch
from
61eb26c to
b220568
Compare
|
Is it possible to add a test for this change? |
|
@jasnell done |
matthieusieben
force-pushed
the
fix-52721
branch
3 times, most recently
from
5d423c6 to
7df71f8
Compare
matthieusieben
force-pushed
the
fix-52721
branch
from
7df71f8 to
681ccbf
Compare
|
@jasnell Is there anything else you need ? |
jasnell
approved these changes
May 4, 2024
aduh95
added
the
author ready
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c75675c |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
PR-URL: #52722 Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52722 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52722 Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52722 Reviewed-By: James M Snell <jasnell@gmail.com>
sophob
pushed a commit
to sophob/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52722 Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52722 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52721