Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x] build: compile with C++20 support #52838

Closed
wants to merge 1 commit into from
Closed

[v22.x] build: compile with C++20 support #52838

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented May 5, 2024

Same goal as #45427 but without affecting external consumers of common.gypi.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels May 5, 2024
targos added a commit to nodejs/build that referenced this pull request May 5, 2024
@targos
jenkins: skip Alpine 3.18 on Node.js >=22
12fa548 
Required if we want to backport C++20 support on Node.js 22.

Refs: nodejs/node#52838
@targos targos mentioned this pull request May 5, 2024
Merged
targos added a commit to nodejs/build that referenced this pull request May 6, 2024
@targos
jenkins: skip Alpine 3.18 on Node.js >=22 (#3703)
a493573 
Required if we want to backport C++20 support on Node.js 22.

Refs: nodejs/node#52838
targos added a commit to nodejs/build that referenced this pull request May 6, 2024
@targos
jenkins: always select gcc-11 on Debian 12
c3dd754 
Refs: nodejs/node#52838
@targos targos mentioned this pull request May 6, 2024
Merged
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2024
targos added a commit to nodejs/build that referenced this pull request May 8, 2024
@targos
jenkins: always select gcc-11 on Debian 12 (#3704)
102f630 
Refs: nodejs/node#52838
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59024/

targos added a commit that referenced this pull request May 8, 2024
@targos
build: compile with C++20 support
e4b1874 
PR-URL: #52838
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos
Copy link
Member Author

targos commented May 8, 2024

Landed in e4b1874

@targos targos closed this May 8, 2024
@targos targos deleted the c++20-node22 branch May 8, 2024 07:02
@targos targos mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@targos @nodejs-github-bot @anonrig @VoltrexKeyva