tools: use sccache GitHub action #52839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
I'll push the yaml lint fix after the test workflow is finished so we can see if it then uses the cache |
|
Build time without cache: 1h21m |
MoLow
approved these changes
May 5, 2024
MoLow
reviewed
May 5, 2024
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
MoLow
approved these changes
May 5, 2024
Certainly, but I suggest we start only with one and monitor it for a few days before applying to others. |
anonrig
approved these changes
May 5, 2024
|
I think the third run didn't use the previous cache because of c7e4209. I restarted it. |
targos
added
the
author ready
benjamingr
approved these changes
May 5, 2024
marco-ippolito
approved these changes
May 5, 2024
lpinca
approved these changes
May 5, 2024
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/52839 ✔ Done loading data for nodejs/node/pull/52839 ----------------------------------- PR info ------------------------------------ Title tools: use sccache GitHub action (#52839) Author Michaël Zasso (@targos) Branch targos:sccache -> nodejs:main Labels meta, fast-track, author ready Commits 3 - tools: use sccache GitHub action - lint - Update .github/workflows/test-linux.yml Committers 2 - Michaël Zasso - GitHub PR-URL: https://github.com/nodejs/node/pull/52839 Refs: https://github.com/Mozilla-Actions/sccache-action Reviewed-By: Moshe Atlow Reviewed-By: Yagiz Nizipli Reviewed-By: Benjamin Gruenbaum Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52839 Refs: https://github.com/Mozilla-Actions/sccache-action Reviewed-By: Moshe Atlow Reviewed-By: Yagiz Nizipli Reviewed-By: Benjamin Gruenbaum Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 05 May 2024 11:45:39 GMT ✔ Approvals: 5 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039719111 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039729543 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039764491 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039767711 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039778872 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52839 From https://github.com/nodejs/node * branch refs/pull/52839/merge -> FETCH_HEAD ✔ Fetched commits as e5a76f16e11b..4961c7af469f -------------------------------------------------------------------------------- [main 6db8a08c4c] tools: use sccache GitHub action Author: Michaël Zasso Date: Sun May 5 13:45:10 2024 +0200 1 file changed, 8 insertions(+) [main 2426339528] lint Author: Michaël Zasso Date: Sun May 5 16:35:16 2024 +0200 1 file changed, 2 insertions(+), 2 deletions(-) [main 9cf34aa272] Update .github/workflows/test-linux.yml Author: Michaël Zasso Date: Sun May 5 17:12:07 2024 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/8965783780 |
nodejs-github-bot
added
the
commit-queue-failed
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in bbace72 |
Ch3nYuY
pushed a commit
to Ch3nYuY/node
that referenced
this pull request
May 8, 2024
Refs: https://github.com/Mozilla-Actions/sccache-action PR-URL: nodejs#52839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
added a commit
that referenced
this pull request
May 8, 2024
Refs: https://github.com/Mozilla-Actions/sccache-action PR-URL: #52839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
@targos WDYT abod expanding this to other workflows now that is seems to work nicely? |
|
SGTM |
lukins-cz
pushed a commit
to lukins-cz/OS-Aplet-node
that referenced
this pull request
Jun 1, 2024
Refs: https://github.com/Mozilla-Actions/sccache-action PR-URL: nodejs#52839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/Mozilla-Actions/sccache-action