meta: security hardening for github actions #52927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
Closing (for now), If this change is still wanted, let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that the CI system has recently been updated to mandate an approving review for code safety. Some verification can be automated, hence this PR.
From my security research in many github repos, I've noticed that certain variables are frequently overlooked. This PR veirifies that said variables don't contain malicious content. While I don't think any of these insecure variables are used in the Node.js ecosystem insecurely, I still think it's safe to verify that they don't contain malicious content, as a pre-emptive measure.
Currently,
<>'"&;{}are all considered 'unsafe' if they are in a branch name (base/head), commiter email, commiter repo name, or commiter user name@nodejs/actions
@nodejs/security-wg