Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove reference to AUTHORS file #52960

Merged
merged 1 commit into from May 14, 2024
Merged

doc: remove reference to AUTHORS file #52960

merged 1 commit into from May 14, 2024

Conversation

marco-ippolito
Copy link
Member

AUTHORS file has been removed in #46845, so that reference is useless

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 12, 2024
aduh95
aduh95 approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth removing because "1000+ contributors" is quite outdated, there are close to 3.5k contributors to nodejs/node according to GitHub.

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 12, 2024
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2024
@nodejs-github-bot nodejs-github-bot merged commit 9807ede into nodejs:main May 14, 2024
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9807ede

@targos targos mentioned this pull request May 15, 2024
Merged
targos added a commit to targos/node that referenced this pull request May 15, 2024
@targos @marco-ippolito
doc: remove reference to AUTHORS file (#18)
adf6657 
PR-URL: nodejs#52960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
targos pushed a commit that referenced this pull request May 15, 2024
@marco-ippolito @targos
doc: remove reference to AUTHORS file
8e5844c 
PR-URL: #52960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

@aymen94 aymen94 aymen94 approved these changes

@aduh95 aduh95 aduh95 approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet