Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post for v10 LTS to v12 LTS #2701

Merged
merged 14 commits into from
Dec 8, 2019
Merged

Add blog post for v10 LTS to v12 LTS #2701

merged 14 commits into from
Dec 8, 2019

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Oct 18, 2019

Adds a blog post that contains all change logs from v11.0.0 to v12.12.0, in addition to a section of highlights from "Notable Changes" of each of those posts.

Ideally, this is meant to be a handy utility for those who are interested in the high level changes that may not be extremely obvious in addition to deeper context from a single source.

Adds a blog post that contains all change logs from v11.0.0 to v12.12.0, in addition to a section of highlights from "Notable Changes" of each of those posts.
locale/en/blog/uncategorized/10-lts-to-12-lts.md Outdated Show resolved Hide resolved
locale/en/blog/uncategorized/10-lts-to-12-lts.md Outdated Show resolved Hide resolved
locale/en/blog/uncategorized/10-lts-to-12-lts.md Outdated Show resolved Hide resolved
locale/en/blog/uncategorized/10-lts-to-12-lts.md Outdated Show resolved Hide resolved
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
Comment on lines +82 to +85
* Added [Jiawen Geng](https://github.com/gengjiawen) to collaborators [#28322](https://github.com/nodejs/node/pull/28322).
* Added [Christian Clauss](https://github.com/cclauss) to collaborators [#27554](https://github.com/nodejs/node/pull/27554).
* Added [Yongsheng Zhang](https://github.com/ZYSzys) to collaborators [#26730](https://github.com/nodejs/node/pull/26730).
* [Gireesh Punathil](https://github.com/gireeshpunathil) is now a member of the Technical Steering Committee [#26657](https://github.com/nodejs/node/pull/26657).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are notable but I wonder if it's more things that happened in the time period rather than being specific to the version of Node.js (they're in the release notes because the README gets updated).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed things that happened within the time period between 10 LTS and 12 LTS. I still think it's valuable to include in this context :)

@bnb
Copy link
Contributor Author

bnb commented Oct 28, 2019

Would love a go/no go on this @Trott, @mhdawson, @jasnell ❤️

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the already pointed out typo fixed :-)

Trott
Trott previously requested changes Oct 28, 2019
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some fixes before publishing, but would certainly like to see it get published soon!

@Trott
Copy link
Member

Trott commented Oct 28, 2019

The last line looks incomplete. Was the file truncated?

@nschonni
Copy link
Member

@bnb are you still working on this?

@bnb
Copy link
Contributor Author

bnb commented Nov 30, 2019

I’d be happy to if we still want to ship it. Will wrap things up on Monday and others can decide if we want to ship it - totally okay if not 👍

@aymen94
Copy link
Member

aymen94 commented Dec 7, 2019

LGTM

bnb and others added 2 commits December 7, 2019 07:59
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Thomas Parisot <oncletom@users.noreply.github.com>
@bnb
Copy link
Contributor Author

bnb commented Dec 7, 2019

@Trott if you don't think it's too late, happy to merge still. Also totally understandable if it is indeed too late 👍

@Trott Trott dismissed their stale review December 8, 2019 02:47

comments addressed (I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants