Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows ARM64 download buttons #5264

Merged
merged 1 commit into from Apr 14, 2023
Merged

Add Windows ARM64 download buttons #5264

merged 1 commit into from Apr 14, 2023

Conversation

StefanStojanovic
Copy link
Contributor

Since Node.js supports Windows ARM64 as a tier 2 platform starting with v19.9.0 onward, this PR adds download buttons for the Windows ARM64 installer and binaries. The PrimaryDownlodMatrix.tsx is changed to check the Node.js version, and add ARM64 buttons for versions that include it.

Old Layout

image

New Layout

image

cc @RafaelGSS

Refs: nodejs/node#47233
Refs: #5263

@StefanStojanovic
fix(download): add win arm64 download buttons
6cc5d38 
Starting with Node.js v19.9.0, Windows on ARM64 binaries are added to
the official builds. This change adds the ARM64 installer and binary
download buttons for versions that include them.
@StefanStojanovic StefanStojanovic requested a review from a team as a code owner April 12, 2023 15:28
ovflowd
ovflowd approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sounds good to me. Just a FYI that this layout will in the near future be discarded in favour of the ones you see on nodejs.dev

@StefanStojanovic
Copy link
Contributor Author

LGTM! Sounds good to me. Just a FYI that this layout will in the near future be discarded in favour of the ones you see on nodejs.dev

Thanks for that info @ovflowd. I see https://github.com/nodejs/nodejs.dev has been archived recently, so can you let me know where I should open an issue or a PR to ensure these newly added buttons are not lost when migrating to the new layout?

@ovflowd
Copy link
Member

ovflowd commented Apr 13, 2023

Thanks for that info @ovflowd. I see nodejs/nodejs.dev has been archived recently, so can you let me know where I should open an issue or a PR to ensure these newly added buttons are not lost when migrating to the new layout?

You can open the issue in this very repository :) as feature request. Once we start migrate the respective components we will ensure that this is added!

@ovflowd ovflowd merged commit b40c70c into nodejs:main Apr 14, 2023
3 checks passed
@StefanStojanovic StefanStojanovic mentioned this pull request Apr 14, 2023
Closed
@StefanStojanovic
Copy link
Contributor Author

You can open the issue in this very repository :) as feature request. Once we start migrate the respective components we will ensure that this is added!

I was waiting for this PR to land and now I opened an issue as suggested. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@aymen94 aymen94 aymen94 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StefanStojanovic @ovflowd @aymen94 @RafaelGSS