Added border bottom to Sideabar of about page

[TenzDelek]

Fixes #6677

Description

• as discuss in the issue, the separation of the title and the sub content done with the adding a border bottom to the title

Validation

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run npm run format to ensure the code follows the style guide.
• I have run npm run test to check if all tests are passing.
• I have run npx turbo build to check if the website builds without errors.
• I've covered new added functionality with unit tests if necessary.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 4, 2024 2:16pm

[AugustinMauroy]

Maybe use border-neutral-200 for light and border-neutral-800 for dark, to make it less aggressive

[TenzDelek]

Maybe use border-neutral-200 for light and border-neutral-800 for dark, to make it less aggressive

sure

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 97	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 99	🟢 100	🟢 96	🟢 92	🔗

[github-actions]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.04% (588/653)	76.08% (175/230)	92.18% (118/128)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
128	0 💤	0 ❌	0 🔥	5.89s ⏱️

[AugustinMauroy]

IMHO, it's good !
Thanks for this first contribution.

[TenzDelek]

IMHO, it's good ! Thanks for this first contribution.

my pleasure, looking forward to do more!!

[ovflowd]

It genuinely looks weird and doesn't fit our design system. Sorry, I'm against this change (but appreciate the time you've put into this).

[TenzDelek]

It genuinely looks weird and doesn't fit our design system. Sorry, I'm against this change (but appreciate the time you've put into this).

appreciate your input on this, but i still believe we need some sort of a visual distinction between them. one way I thought is darken out the title a little. if this still feels unnecessary , i will close this pr.. @ovflowd

[ovflowd]

Let me mutter a bit about variants we could create, and Ill come back to you :)

[TenzDelek]

Let me mutter a bit about variants we could create, and Ill come back to you :)

sure 😃

[TenzDelek]

Let me mutter a bit about variants we could create, and Ill come back to you :)

@ovflowd any thought on this ?

[ovflowd]

Let me mutter a bit about variants we could create, and Ill come back to you :)

@ovflowd any thought on this ?

Unfortunately haven't putten time into this yet, something I was cogitating/thinking was in line of this:

OR this:

[TenzDelek]

@ovflowd , seeing the reaction of the team , i dont think the above design is feasible for now. for these pass days , i came up with a design that maybe suitable enough. (added a + sign and darken the header for better seperation). what do you think? :)

[AugustinMauroy]

maybe without the + it's can be ok

[TenzDelek]

maybe without the + it's can be ok

sure will remove that !!

[mikeesto]

I think this is an improvement over what we currently have so +1 from me

[AugustinMauroy]

LGTM ! Lighthouse contrast ratio is passing 🎉

[ovflowd]

The headers being dark is definitely a nimble and good solution :)

[ovflowd]

@ovflowd , seeing the reaction of the team , i dont think the above design is feasible for now. for these pass days , i came up with a design that maybe suitable enough. (added a + sign and darken the header for better seperation). what do you think? :)

It is important to mention those are just random ideas Ive come up in 5 minutes.

[ovflowd]

LGTM. Thank you for your first contribution ;)